linux-kernel - Re: [PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d3bd0be-5b8a-4a3f-bc82-cb1b72fc1899@quicinc.com>
Date: Mon, 5 Aug 2024 09:51:16 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>
CC: <kernel@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450



On 8/2/2024 3:20 PM, Krzysztof Kozlowski wrote:
> On 01/08/2024 10:54, Tengfei Fan wrote:
>> Add the SM4450 interconnect driver as built-in.
> 
> This we see from the diff. Tell us instead: why?
> 
> That's a standard requirement for every defconfig change. Damn, for
> every change. Don't say what the diff is saying, unless it is
> non-trivial. Say why you are doing things.
> 
> Best regards,
> Krzysztof
> 

In the next version of the patch series, I will describe in the comment 
message why this config needs to be enabled.

-- 
Thx and BRs,
Tengfei Fan