linux-kernel - RE: [PATCH v2 2/2] gpio: vf610: add get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB949645FC8DDB14D7976D594E90BE2@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Mon, 5 Aug 2024 02:08:26 +0000
From: Bough Chen <haibo.chen@....com>
To: Stefan Wahren <wahrenst@....net>, "linus.walleij@...aro.org"
	<linus.walleij@...aro.org>, "brgl@...ev.pl" <brgl@...ev.pl>
CC: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH v2 2/2] gpio: vf610: add get_direction() support


> -----Original Message-----
> From: Stefan Wahren <wahrenst@....net>
> Sent: 2024年8月2日 21:22
> To: Bough Chen <haibo.chen@....com>; linus.walleij@...aro.org;
> brgl@...ev.pl
> Cc: linux-gpio@...r.kernel.org; linux-kernel@...r.kernel.org;
> imx@...ts.linux.dev
> Subject: Re: [PATCH v2 2/2] gpio: vf610: add get_direction() support
> 
> Hi Haibo,
> 
> Am 01.08.24 um 11:30 schrieb haibo.chen@....com:
> > From: Haibo Chen <haibo.chen@....com>
> >
> > For IP which do not contain PDDR, currently use the pinmux API
> > pinctrl_gpio_direction_input() to config the output/input, pinmux
> > currently do not support get_direction(). So here add the GPIO
> > get_direction() support only for the IP which has Port Data Direction
> > Register (PDDR).
> just a question about how things work:
> 
> fsl,imx7ulp-gpio and i.MX93 have PDDR, so GPIO get_direction is handled in
> gpio-vf610 driver fsl,vf610-gpio doesn't have PDDR, so all GPIO direction stuff is
> handled in pinctrl-vf610 driver
> 
> Is this correct?

Yes, correct. vf610_pmx_gpio_set_direction() did that.

Best Regards
Haibo Chen

> 
> Best regards