linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8183: Remove clock from mfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e089dc0-9342-480f-ac8a-93b5bfe1241e@collabora.com>
Date: Mon, 5 Aug 2024 13:46:22 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Pin-yen Lin <treapking@...omium.org>,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: Rob Herring <robh@...nel.org>,
 Kiwi Liu <kiwi.liu@...iatek.corp-partner.google.com>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 Enric Balletbo i Serra <eballetbo@...nel.org>,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Hsin-Te Yuan <yuanhsinte@...omium.org>, Chen-Yu Tsai <wenst@...omium.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: Remove clock from mfg_async
 power domain

Il 05/08/24 08:50, Pin-yen Lin ha scritto:
> This clock dependency introduced a mutual dependency between mfg_async
> power domain and mt8183-mfgcfg clock, and Mediatek has confirmed that
> this dependency is not needed. Remove this to avoid potential deadlock.
> 

Uhm, have you tested this upstream with Panfrost, or only downstream with the
proprietary Mali stack?

Regards,
Angelo

> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller")
> 
> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index fbf145639b8c..267378fa46c0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -872,8 +872,6 @@ power-domain@...183_POWER_DOMAIN_CONN {
>   
>   				mfg_async: power-domain@...183_POWER_DOMAIN_MFG_ASYNC {
>   					reg = <MT8183_POWER_DOMAIN_MFG_ASYNC>;
> -					clocks = <&topckgen CLK_TOP_MUX_MFG>;
> -					clock-names = "mfg";
>   					#address-cells = <1>;
>   					#size-cells = <0>;
>   					#power-domain-cells = <1>;