linux-kernel - Re: [PATCH RESEND v4 0/6] dmaengine: dw: Fix src/dst addr width misconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rsy7z45nhl74nzvq5a2ij4eeqgzu3htje2xpparxgam7jowo6a@6l75wjh2dqll>
Date: Mon, 5 Aug 2024 15:25:35 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Viresh Kumar <vireshk@...nel.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andy Shevchenko <andy@...nel.org>, Vinod Koul <vkoul@...nel.org>, 
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jiri Slaby <jirislaby@...nel.org>, dmaengine@...r.kernel.org, linux-serial@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v4 0/6] dmaengine: dw: Fix src/dst addr width
 misconfig

Hi Andy,

On Sat, Aug 03, 2024 at 09:29:54PM +0200, Andy Shevchenko wrote:
> On Fri, Aug 2, 2024 at 9:51 AM Serge Semin <fancer.lancer@...il.com> wrote:
> >
> > The main goal of this series is to fix the data disappearance in case of
> > the DW UART handled by the DW AHB DMA engine. The problem happens on a
> > portion of the data received when the pre-initialized DEV_TO_MEM
> > DMA-transfer is paused and then disabled. The data just hangs up in the
> > DMA-engine FIFO and isn't flushed out to the memory on the DMA-channel
> > suspension (see the second commit log for details). On a way to find the
> > denoted problem fix it was discovered that the driver doesn't verify the
> > peripheral device address width specified by a client driver, which in its
> > turn if unsupported or undefined value passed may cause DMA-transfer being
> > misconfigured. It's fixed in the first patch of the series.
> >
> > In addition to that three cleanup patches follow the fixes described above
> > in order to make the DWC-engine configuration procedure more coherent.
> > First one simplifies the CTL_LO register setup methods. Second and third
> > patches simplify the max-burst calculation procedure and unify it with the
> > rest of the verification methods. Please see the patches log for more
> > details.
> >
> > Final patch is another cleanup which unifies the status variables naming
> > in the driver.
> 
> Acked-by: Andy Shevchenko <andy@...nel.org>

Awesome! Thanks.

-Serge(y)

> 
> -- 
> With Best Regards,
> Andy Shevchenko