linux-kernel - Re: [PATCH] drm/omap: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5098c86a-2838-45c5-9590-ede0d1189bdd@ideasonboard.com>
Date: Mon, 5 Aug 2024 15:54:10 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Arnd Bergmann <arnd@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc: Arnd Bergmann <arnd@...db.de>, Nathan Chancellor <nathan@...nel.org>,
 Helge Deller <deller@....de>, Tony Lindgren <tony@...mide.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/omap: add CONFIG_MMU dependency

Hi,

On 19/07/2024 12:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:
> 
> arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault_2d':
> omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_mixed'
> arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault':
> omap_gem.c:(.text+0x74a): undefined reference to `vmf_insert_mixed'
> 
> Avoid this by adding a Kconfig dependency.
> 
> Fixes: dc6fcaaba5a5 ("drm/omap: Allow build with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applying to drm-misc-fixes.

  Tomi

> ---
>   drivers/gpu/drm/omapdrm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 3f7139e211d2..64e440a2649b 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -1,6 +1,7 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   config DRM_OMAP
>   	tristate "OMAP DRM"
> +	depends on MMU
>   	depends on DRM && OF
>   	depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB)
>   	select DRM_KMS_HELPER