linux-kernel - Re: [PATCH v3] phy: qcom: qmp: Add debug prints for register writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240805140606.GD7274@thinkpad>
Date: Mon, 5 Aug 2024 19:36:06 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Vinod Koul <vkoul@...nel.org>
Cc: kishon@...nel.org, linux-arm-msm@...r.kernel.org,
	linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
	dmitry.baryshkov@...aro.org
Subject: Re: [PATCH v3] phy: qcom: qmp: Add debug prints for register writes

On Sun, Aug 04, 2024 at 10:09:09PM +0530, Vinod Koul wrote:
> On 01-08-24, 12:30, Manivannan Sadhasivam wrote:
> > On Thu, Aug 01, 2024 at 12:25:20PM +0530, Vinod Koul wrote:
> > > 
> > > On Wed, 31 Jul 2024 20:55:48 +0530, Manivannan Sadhasivam wrote:
> > > > These register prints are useful to validate the init sequence against the
> > > > Qcom internal documentation and also to share with the Qcom hw engineers to
> > > > debug issues related to PHY.
> > > > 
> > > > Sample debug prints:
> > > > 
> > > > qcom-qmp-pcie-phy 1c0e000.phy: Writing Reg: QSERDES_V5_COM_SYSCLK_EN_SEL Offset: 0x0094 Val: 0xd9
> > > > qcom-qmp-pcie-phy 1c0e000.phy: Writing Reg: QSERDES_V5_COM_HSCLK_SEL Offset: 0x0158 Val: 0x11
> > > > 
> > > > [...]
> > > 
> > > Applied, thanks!
> > > 
> > > [1/1] phy: qcom: qmp: Add debug prints for register writes
> > >       commit: 4e92d504475ea5841716ad775f412342520a3d26
> > > 
> > 
> > Thanks! Bjorn spotted that it is worth making 'char *name' a const. Can you
> > please ammend the commit?
> 
> Send a patch please, I dont like to rebase
> 

Ok, will do.

- Mani

-- 
மணிவண்ணன் சதாசிவம்