linux-kernel - RE: [PATCH v3 6/7] Drivers: hv: vmbus: Get the IRQ number from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB415701C313BD5E296393A29DD4BE2@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Mon, 5 Aug 2024 14:12:41 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Saurabh Singh Sengar <ssengar@...ux.microsoft.com>, Roman Kisel
	<romank@...ux.microsoft.com>
CC: "arnd@...db.de" <arnd@...db.de>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "bp@...en8.de" <bp@...en8.de>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"decui@...rosoft.com" <decui@...rosoft.com>, "haiyangz@...rosoft.com"
	<haiyangz@...rosoft.com>, "hpa@...or.com" <hpa@...or.com>, "kw@...ux.com"
	<kw@...ux.com>, "kys@...rosoft.com" <kys@...rosoft.com>, "lenb@...nel.org"
	<lenb@...nel.org>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>, "rafael@...nel.org"
	<rafael@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "wei.liu@...nel.org"
	<wei.liu@...nel.org>, "will@...nel.org" <will@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>,
	"apais@...rosoft.com" <apais@...rosoft.com>, "benhill@...rosoft.com"
	<benhill@...rosoft.com>, "ssengar@...rosoft.com" <ssengar@...rosoft.com>,
	"sunilmut@...rosoft.com" <sunilmut@...rosoft.com>, "vdso@...bites.dev"
	<vdso@...bites.dev>
Subject: RE: [PATCH v3 6/7] Drivers: hv: vmbus: Get the IRQ number from DT

From: Saurabh Singh Sengar <ssengar@...ux.microsoft.com> Sent: Monday, August 5, 2024 1:30 AM
> 
> On Fri, Jul 26, 2024 at 03:59:09PM -0700, Roman Kisel wrote:
> > The VMBus driver uses ACPI for interrupt assignment on
> > arm64 hence it won't function in the VTL mode where only
> > DeviceTree can be used.
> >
> > Update the VMBus driver to discover interrupt configuration
> > via DeviceTree and indicate DMA cache coherency.
> >
> > Signed-off-by: Roman Kisel <romank@...ux.microsoft.com>
> > ---
> >  drivers/hv/vmbus_drv.c | 49 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index 12a707ab73f8..7eee7caff5f6 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -2306,6 +2306,34 @@ static int vmbus_acpi_add(struct platform_device *pdev)
> >  }
> >  #endif
> >
> > +static int __maybe_unused vmbus_set_irq(struct platform_device *pdev)
> > +{
> > +	struct irq_desc *desc;
> > +	int irq;
> > +
> > +	irq = platform_get_irq(pdev, 0);
> > +	if (irq == 0) {
> > +		pr_err("VMBus interrupt mapping failure\n");
> > +		return -EINVAL;
> > +	}
> > +	if (irq < 0) {
> > +		pr_err("VMBus interrupt data can't be read from DeviceTree, error %d\n", irq);
> > +		return irq;
> > +	}
> > +
> > +	desc = irq_to_desc(irq);
> 
> irq_to_desc is not an exported symbol if CONFIG_SPARSE_IRQ is enabled. This will
> break the builds for HYPERV as module.
> 

Instead, use irq_get_irq_data(), then irqd_to_hwirq().

Michael