linux-kernel - Re: [PATCH] selinux: Fix potential counting error in avc_add_xperms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <600318b9-928c-4466-a8d1-334fab8c512f@web.de>
Date: Tue, 6 Aug 2024 18:30:47 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zhen Lei <thunder.leizhen@...wei.com>, selinux@...r.kernel.org,
 Ondrej Mosnacek <omosnace@...hat.com>, Paul Moore <paul@...l-moore.com>,
 Stephen Smalley <stephen.smalley.work@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Jeff Vander Stoep
 <jeffv@...gle.com>, Nick Kralevich <nnk@...gle.com>
Subject: Re: [PATCH] selinux: Fix potential counting error in
 avc_add_xperms_decision()

> The count increases only when a node is successfully added to
> the linked list.

1. Please improve such a change description with an imperative wording.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc2#n94

2. How do you think about to omit the word “potential” from the summary phrase?

Regards,
Markus