linux-kernel - RE: [PATCH net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR21MB4363D5A242047944FBAB42B4CABF2@PH0PR21MB4363.namprd21.prod.outlook.com>
Date: Tue, 6 Aug 2024 15:56:14 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Long Li <longli@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>, Wei Liu
	<wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shradha Gupta
	<shradhagupta@...ux.microsoft.com>, Simon Horman <horms@...nel.org>,
	Konstantin Taranov <kotaranov@...rosoft.com>, Souradeep Chakrabarti
	<schakrabarti@...ux.microsoft.com>, Erick Archer <erick.archer@...look.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
CC: "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH net] net: mana: Fix doorbell out of order violation and
 avoid unnecessary doorbell rings



> -----Original Message-----
> From: longli@...uxonhyperv.com <longli@...uxonhyperv.com>
> Sent: Monday, August 5, 2024 7:38 PM
> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; Wei Liu <wei.liu@...nel.org>; Dexuan Cui
> <decui@...rosoft.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Shradha Gupta <shradhagupta@...ux.microsoft.com>;
> Simon Horman <horms@...nel.org>; Konstantin Taranov
> <kotaranov@...rosoft.com>; Souradeep Chakrabarti
> <schakrabarti@...ux.microsoft.com>; Erick Archer
> <erick.archer@...look.com>; linux-hyperv@...r.kernel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> rdma@...r.kernel.org
> Cc: Long Li <longli@...rosoft.com>; stable@...r.kernel.org
> Subject: [PATCH net] net: mana: Fix doorbell out of order violation and
> avoid unnecessary doorbell rings
> 
> From: Long Li <longli@...rosoft.com>
> 
> After napi_complete_done() is called, another NAPI may be running on
> another CPU and ring the doorbell before the current CPU does. When
> combined with unnecessary rings when there is no need to ARM the CQ, this
> triggers error paths in the hardware.
> 
> Fix this by always ring the doorbell in sequence and avoid unnecessary
> rings.
> 
> Cc: stable@...r.kernel.org
> Fixes: e1b5683ff62e ("net: mana: Move NAPI from EQ to CQ")
> Signed-off-by: Long Li <longli@...rosoft.com>

Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>

Thank you.