linux-kernel - Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a03c0609-cc13-457b-84ec-5880fc553bd8@roeck-us.net>
Date: Tue, 6 Aug 2024 09:44:16 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Frank Li <Frank.li@....com>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: Animesh Agarwal <animeshagarwal28@...il.com>,
 Daniel Baluta <daniel.baluta@....com>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, linux-watchdog@...r.kernel.org,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing
 'big-endian' property

On 8/6/24 08:49, Frank Li wrote:
> On Tue, Aug 06, 2024 at 12:43:07PM +0200, Krzysztof Kozlowski wrote:
>> On 06/08/2024 12:38, Animesh Agarwal wrote:
>>> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema.
>>> This fixes dtbs_check errors.
>>>
>>> Cc: Daniel Baluta <daniel.baluta@....com>
>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
>>> ---
>>> There are 12 similar errors related to this missing property from
>>> different blobs.
>>>
>>> ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@...0000:
>>> Unevaluated properties are not allowed ('big-endian' was unexpected)from
>>> schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
>>> ---
>>
>> Not sure if this is correct. I mean, technically it is, but Frank Li was
>> removing big-endian properties so please choose consistent approach.
> 
> drivers/watchdog/imx2_wdt.c never parser big-endian. I suggest remove
> big-endian in dts file. I suggest keep big-endian only if it really used.
> 

Agreed.

Guenter