linux-kernel - Re: [PATCH -next] spmi: pmic-arb: Add check for return value of platform_get_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b34788391df96f39025d2b1ce47e6d26.sboyd@kernel.org>
Date: Tue, 06 Aug 2024 10:50:44 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: cuigaosheng <cuigaosheng1@...wei.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] spmi: pmic-arb: Add check for return value of platform_get_resource_byname

Quoting cuigaosheng (2024-08-06 05:06:40)
> Thanks for your time.

Please don't top post.

> 
> I've made and submitted a patch v2, and I think the right fixes tag is 
> as follows:
> 
> Fixes: 39ae93e3a31d ("spmi: Add MSM PMIC Arbiter SPMI controller")

Don't think so. If the resource isn't there, the pointer returned is
NULL, devm_ioremap_resource() would bail out early if the resource is
NULL and return an error. I suggested that fixes tag because it removed
the size check. But now I see that resource_size() on a NULL pointer
would blow up. So the real fixes tag is

Fixes: 987a9f128b8a ("spmi: pmic-arb: Support more than 128 peripherals")

because that introduced the call to resource_size() on a potentially
NULL pointer.