linux-kernel - Re: [PATCH v3 09/14] xfs: Update xfs_setattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806190313.GL623936@frogsfrogsfrogs>
Date: Tue, 6 Aug 2024 12:03:13 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: John Garry <john.g.garry@...cle.com>
Cc: chandan.babu@...cle.com, dchinner@...hat.com, hch@....de,
	viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz,
	linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, catherine.hoang@...cle.com,
	martin.petersen@...cle.com
Subject: Re: [PATCH v3 09/14] xfs: Update xfs_setattr_size() for forcealign

On Thu, Aug 01, 2024 at 04:30:52PM +0000, John Garry wrote:
> For when an inode has forcealign, reserve blocks for same reason which we
> were doing for big RT alloc.
> 
> Signed-off-by: John Garry <john.g.garry@...cle.com>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
>  fs/xfs/xfs_iops.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 1cdc8034f54d..6e017aa6f61d 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -926,12 +926,12 @@ xfs_setattr_size(
>  	}
>  
>  	/*
> -	 * For realtime inode with more than one block rtextsize, we need the
> +	 * For inodes with more than one block alloc unitsize, we need the
>  	 * block reservation for bmap btree block allocations/splits that can
>  	 * happen since it could split the tail written extent and convert the
>  	 * right beyond EOF one to unwritten.
>  	 */
> -	if (xfs_inode_has_bigrtalloc(ip))
> +	if (xfs_inode_alloc_fsbsize(ip) > 1)
>  		resblks = XFS_DIOSTRAT_SPACE_RES(mp, 0);
>  
>  	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_itruncate, resblks,
> -- 
> 2.31.1
> 
>