linux-kernel - Re: [PATCH v3] lib: Convert test_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408061232.B6382B6DA0@keescook>
Date: Tue, 6 Aug 2024 12:34:23 -0700
From: Kees Cook <kees@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Vitor Massaru Iha <vitor@...saru.org>, kunit-dev@...glegroups.com,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	brendanhiggins@...gle.com, davidgow@...gle.com,
	skhan@...uxfoundation.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v3] lib: Convert test_user_copy to KUnit test

On Tue, Aug 06, 2024 at 08:48:43AM -0700, Guenter Roeck wrote:
> Hi,
> 
> On Tue, Jul 21, 2020 at 02:46:54PM -0300, Vitor Massaru Iha wrote:
> > This adds the conversion of the runtime tests of test_user_copy fuctions,
> > from `lib/test_user_copy.c`to KUnit tests.
> > 
> > Signed-off-by: Vitor Massaru Iha <vitor@...saru.org>
> 
> These tests are failing (at least) for arm-v7, loongarch, and mips
> qemu emulations; see below for failure logs.

Oh my. Good thing this got added to KUnit, then -- the core of the tests
haven't actually changed. I will see what I can uncover.

> Any idea if those might be architecture problems, problems with qemu,
> or problems with the test ?

The last two look like NULL derefs (??) and the first seems like maybe a
test problem (the failure looks kind of like the CONFIG_MMU=n cases that
were fixed earlier).

-- 
Kees Cook