linux-kernel - Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23e8b9d9-d0e0-44df-b464-fc2d1f2d5507@gmail.com>
Date: Tue, 6 Aug 2024 21:45:07 +0100
From: Mudit Sharma <muditsharma.info@...il.com>
To: Matti Vaittinen <mazziesaccount@...il.com>, jic23@...nel.org,
 lars@...afoo.de, krzk+dt@...nel.org, conor+dt@...nel.org, robh@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, Ivan Orlov <ivan.orlov0322@...il.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>
Subject: Re: [PATCH v8 2/2] iio: light: ROHM BH1745 colour sensor

On 05/08/2024 11:28, Matti Vaittinen wrote:
> On 7/19/24 01:02, Mudit Sharma wrote:
>> Add support for BH1745, which is an I2C colour sensor with red, green,
>> blue and clear channels. It has a programmable active low interrupt
>> pin. Interrupt occurs when the signal from the selected interrupt
>> source channel crosses set interrupt threshold high or low level.
>>
>> Interrupt source for the device can be configured by enabling the
>> corresponding event. Interrupt latch is always enabled when setting
>> up interrupt.
>>
>> Add myself as the maintainer for this driver in MAINTAINERS.
>>
>> Signed-off-by: Mudit Sharma <muditsharma.info@...il.com>
>> Reviewed-by: Ivan Orlov <ivan.orlov0322@...il.com>
>> Reviewed-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> 
> Hi Mudit & All :)
> 
> I know I am late. The series has already been applied (thanks 
> Jonathan!). I've mostly been offline for the last 1.5 months or so - 
> "all work and no play makes Jack a dull boy", you know ;)
> 
> Anyways, as Jonathan asked me to take a look at the GTS stuff (at v7), I 
> tried to quickly glance at this. It looks good to me!
> 
> Well, the real test will be the users of the sensor driver - so please 
> let us know if GTS stuff brings problems to users. I am mostly 
> interested in knowing if gain changes caused by integration time changes 
> are handled gracefully by the users. :) Well, seeing there is no per- 
> channel gain or integration time setting, you should be safe from the 
> worst side-effects :)
> 
> Nice driver!

Hi Matti,

Thank you for your review on this :)

Best regards,
Mudit Sharma
> 
> Yours,
>      -- Matti
>