linux-kernel - Re: [PATCH] PCI: remove type return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_RzfZWns316GziuWbX-ZhO-xZm8rhssoC6tAdizGK1s3Ai+g@mail.gmail.com>
Date: Tue, 6 Aug 2024 17:54:15 -0300
From: Guilherme Giácomo Simões <trintaeoitogc@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: bhelgaas@...gle.com, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: remove type return

Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> wrote:

>
> On Sat, 3 Aug 2024, Guilherme Giacomo Simoes wrote:
>
> > I can see that the function pci_hp_add_brigde have a int return propagation.
>
> typo in function name. Add parenthesis after function names like this:
> pci_hp_add_bridge()
>
> > But in the drivers that pci_hp_add_bridge is called, your return never is
> > cheked.
>
> checked.
>
> > This make me a think that the add bridge for pci hotplug drivers is not crucial
> > for functionaly and your failed only should show a message in logs.
>
> functionality
>
> >
> > Then, I maked this patch for remove your return propagation for this moment.
>
> Please write the commit message using imperative tone. Don't use "I",
> "me", "you", "your", or "we" at all.
>
> Also, you need to signoff your patches (please read
> Documentation/process/submitting-patches.rst).
>
> The lack of return value checking seems to be on the list in
> pci_hp_add_bridge(). So perhaps the right course of action would be to
> handle return values correctly.
>
> --
>  i.
>

Ok, so if the right course is for the driver to handle return value,
then this is a
task for the driver developers, because only they know what to do when
pci_hp_add_bridge() doesn't work correctly, right?