[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFBinCAaZumGU6dOq0RrHRTQV=MejTJ=RW0P_6tQFOG9vybY6g@mail.gmail.com>
Date: Tue, 6 Aug 2024 23:03:25 +0200
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Kevin Hilman <khilman@...libre.com>, dri-devel@...ts.freedesktop.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/9] drm/meson: dw-hdmi: use matched data
Hi Jerome,
On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet <jbrunet@...libre.com> wrote:
[...]
> + }, {
> + .limit = 297000,
> + .regs = gxbb_3g_regs,
> + .reg_num = ARRAY_SIZE(gxbb_3g_regs)
Just as a side-note: this looked odd when reading for the first time
as I thought that it's a typo (and it should be gxbb_2g97_regs - but
that name is not used).
[...]
> +static const struct meson_dw_hdmi_speed gxl_speeds[] = {
> + {
> + .limit = 371250,
> + .regs = gxl_3g7_regs,
> + .reg_num = ARRAY_SIZE(gxl_3g7_regs)
> + }, {
> + .limit = 297000,
> + .regs = gxl_3g_regs,
> + .reg_num = ARRAY_SIZE(gxl_3g_regs)
> + }, {
> + .limit = 148500,
> + .regs = gxl_def_regs,
> + .reg_num = ARRAY_SIZE(gxl_def_regs)
this is not consistent with what we have above or below so it either
needs to be updated or a comment.
I think this should be called gxl_1g48_regs
> + }, {
> + .regs = gxl_270m_regs,
> + .reg_num = ARRAY_SIZE(gxl_270m_regs)
and this should be called gxl_def_regs
Best regards,
Martin
Powered by blists - more mailing lists