[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8a8b93b8-45df-4aaa-95f3-fc2deadf65f1@acm.org>
Date: Tue, 6 Aug 2024 15:01:08 -0700
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <avri.altman@....com>,
"Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: Prepare to add HCI capabilities sysfs
On 8/4/24 12:21 AM, Avri Altman wrote:
> - up(&hba->host_sem);
> - return ret;
> + return sysfs_emit(buf, "%d\n", ufshcd_ahit_to_us(ahit));
> }
All ufshcd_read_hci_reg() callers call sysfs_emit(). How about renaming
ufshcd_read_hci_reg() into ufshcd_show_hci_reg(), adding an argument
that indicates how the result should be formatted and moving the
sysfs_emit() call into ufshcd_show_hci_reg()?
Thanks,
Bart.
Powered by blists - more mailing lists