| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <a24dd146-2991-46af-a6f7-6f2b0a7eb97f@app.fastmail.com>
Date: Wed, 07 Aug 2024 10:20:39 +1200
From: "Luke Jones" <luke@...nes.dev>
To: "kernel test robot" <lkp@...el.com>, linux-input@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, "Benjamin Tissoires" <bentiss@...nel.org>,
"Jiri Kosina" <jikos@...nel.org>
Subject: Re: [PATCH] hid-asus-ally: Add full gamepad support
On Wed, 7 Aug 2024, at 9:34 AM, kernel test robot wrote:
> Hi Luke,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on hid/for-next]
> [also build test WARNING on next-20240806]
> [cannot apply to linus/master v6.11-rc2]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Luke-D-Jones/hid-asus-ally-Add-full-gamepad-support/20240806-170850
> base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
> patch link: https://lore.kernel.org/r/20240806081212.56860-1-luke%40ljones.dev
> patch subject: [PATCH] hid-asus-ally: Add full gamepad support
> config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240807/202408070520.r1N2Tpys-lkp@intel.com/config)
> compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 423aec6573df4424f90555468128e17073ddc69e)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240807/202408070520.r1N2Tpys-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408070520.r1N2Tpys-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> In file included from drivers/hid/hid-asus-ally.c:17:
> In file included from include/linux/hid.h:29:
> In file included from include/linux/hid_bpf.h:6:
> In file included from include/linux/bpf.h:21:
> In file included from include/linux/kallsyms.h:13:
> In file included from include/linux/mm.h:2228:
> include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> 514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
> | ~~~~~~~~~~~ ^ ~~~
> In file included from drivers/hid/hid-asus-ally.c:17:
> In file included from include/linux/hid.h:29:
> In file included from include/linux/hid_bpf.h:6:
> In file included from include/linux/bpf.h:31:
> In file included from include/linux/memcontrol.h:13:
> In file included from include/linux/cgroup.h:25:
> In file included from include/linux/kernel_stat.h:8:
> In file included from include/linux/interrupt.h:11:
> In file included from include/linux/hardirq.h:11:
> In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> In file included from include/asm-generic/hardirq.h:17:
> In file included from include/linux/irq.h:20:
> In file included from include/linux/io.h:14:
> In file included from arch/hexagon/include/asm/io.h:328:
> include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 548 | val = __raw_readb(PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
> | ~~~~~~~~~~ ^
> include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
> 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
> | ^
> In file included from drivers/hid/hid-asus-ally.c:17:
> In file included from include/linux/hid.h:29:
> In file included from include/linux/hid_bpf.h:6:
> In file included from include/linux/bpf.h:31:
> In file included from include/linux/memcontrol.h:13:
> In file included from include/linux/cgroup.h:25:
> In file included from include/linux/kernel_stat.h:8:
> In file included from include/linux/interrupt.h:11:
> In file included from include/linux/hardirq.h:11:
> In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> In file included from include/asm-generic/hardirq.h:17:
> In file included from include/linux/irq.h:20:
> In file included from include/linux/io.h:14:
> In file included from arch/hexagon/include/asm/io.h:328:
> include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
> | ~~~~~~~~~~ ^
> include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
> 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
> | ^
> In file included from drivers/hid/hid-asus-ally.c:17:
> In file included from include/linux/hid.h:29:
> In file included from include/linux/hid_bpf.h:6:
> In file included from include/linux/bpf.h:31:
> In file included from include/linux/memcontrol.h:13:
> In file included from include/linux/cgroup.h:25:
> In file included from include/linux/kernel_stat.h:8:
> In file included from include/linux/interrupt.h:11:
> In file included from include/linux/hardirq.h:11:
> In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> In file included from include/asm-generic/hardirq.h:17:
> In file included from include/linux/irq.h:20:
> In file included from include/linux/io.h:14:
> In file included from arch/hexagon/include/asm/io.h:328:
> include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 585 | __raw_writeb(value, PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> drivers/hid/hid-asus-ally.c:565:10: warning: variable 'max_output_report_size' set but not used [-Wunused-but-set-variable]
> 565 | uint8_t max_output_report_size;
> | ^
> drivers/hid/hid-asus-ally.c:1177:6: warning: variable 'cmd' set but not used [-Wunused-but-set-variable]
> 1177 | int cmd, side, is_tr;
> | ^
> >> drivers/hid/hid-asus-ally.c:894:1: warning: unused variable 'btn_mapping_lt_attr_group' [-Wunused-const-variable]
> 894 | ALLY_BTN_MAPPING(lt, btn_pair_lt_rt, btn_pair_side_left);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/hid-asus-ally.h:321:2: note: expanded from macro 'ALLY_BTN_MAPPING'
> 321 | ALLY_BTN_ATTRS_GROUP(btn_##_fname, btn_mapping_##_fname)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/hid-asus-ally.h:306:38: note: expanded from macro 'ALLY_BTN_ATTRS_GROUP'
> 306 | static const struct attribute_group _fname##_attr_group = { \
> | ^~~~~~~~~~~~~~~~~~~
> <scratch space>:125:1: note: expanded from here
> 125 | btn_mapping_lt_attr_group
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/hid/hid-asus-ally.c:895:1: warning: unused variable 'btn_mapping_rt_attr_group' [-Wunused-const-variable]
> 895 | ALLY_BTN_MAPPING(rt, btn_pair_lt_rt, btn_pair_side_right);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/hid-asus-ally.h:321:2: note: expanded from macro 'ALLY_BTN_MAPPING'
> 321 | ALLY_BTN_ATTRS_GROUP(btn_##_fname, btn_mapping_##_fname)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/hid-asus-ally.h:306:38: note: expanded from macro 'ALLY_BTN_ATTRS_GROUP'
> 306 | static const struct attribute_group _fname##_attr_group = { \
> | ^~~~~~~~~~~~~~~~~~~
> <scratch space>:167:1: note: expanded from here
> 167 | btn_mapping_rt_attr_group
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> 11 warnings generated.
>
>
> vim +/btn_mapping_lt_attr_group +894 drivers/hid/hid-asus-ally.c
>
> 882
> 883 /* button map attributes, regular and macro*/
> 884 ALLY_BTN_MAPPING(m2, btn_pair_m1_m2, btn_pair_side_left);
> 885 ALLY_BTN_MAPPING(m1, btn_pair_m1_m2, btn_pair_side_right);
> 886 ALLY_BTN_MAPPING(a, btn_pair_a_b, btn_pair_side_left);
> 887 ALLY_BTN_MAPPING(b, btn_pair_a_b, btn_pair_side_right);
> 888 ALLY_BTN_MAPPING(x, btn_pair_x_y, btn_pair_side_left);
> 889 ALLY_BTN_MAPPING(y, btn_pair_x_y, btn_pair_side_right);
> 890 ALLY_BTN_MAPPING(lb, btn_pair_lb_rb, btn_pair_side_left);
> 891 ALLY_BTN_MAPPING(rb, btn_pair_lb_rb, btn_pair_side_right);
> 892 ALLY_BTN_MAPPING(ls, btn_pair_ls_rs, btn_pair_side_left);
> 893 ALLY_BTN_MAPPING(rs, btn_pair_ls_rs, btn_pair_side_right);
> > 894 ALLY_BTN_MAPPING(lt, btn_pair_lt_rt, btn_pair_side_left);
> > 895 ALLY_BTN_MAPPING(rt, btn_pair_lt_rt, btn_pair_side_right);
> 896 ALLY_BTN_MAPPING(dpad_u, btn_pair_dpad_u_d, btn_pair_side_left);
> 897 ALLY_BTN_MAPPING(dpad_d, btn_pair_dpad_u_d, btn_pair_side_right);
> 898 ALLY_BTN_MAPPING(dpad_l, btn_pair_dpad_l_r, btn_pair_side_left);
> 899 ALLY_BTN_MAPPING(dpad_r, btn_pair_dpad_l_r, btn_pair_side_right);
> 900 ALLY_BTN_MAPPING(view, btn_pair_view_menu, btn_pair_side_left);
> 901 ALLY_BTN_MAPPING(menu, btn_pair_view_menu, btn_pair_side_right);
> 902
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
I like this service. The above warnings will be fixed in next version after I get some review.
Regards,
Luke.
Powered by blists - more mailing lists