linux-kernel - Re: [PATCH] mm: attempt to batch free swap entries for zap_pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240806154112.5d6e63b527c3a9501ef5a851@linux-foundation.org>
Date: Tue, 6 Aug 2024 15:41:12 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Barry Song <21cnbao@...il.com>
Cc: David Hildenbrand <david@...hat.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Barry Song <v-songbaohua@...o.com>, Kairui
 Song <kasong@...cent.com>, Chris Li <chrisl@...nel.org>, "Huang, Ying"
 <ying.huang@...el.com>, Hugh Dickins <hughd@...gle.com>, Kalesh Singh
 <kaleshsingh@...gle.com>, Ryan Roberts <ryan.roberts@....com>
Subject: Re: [PATCH] mm: attempt to batch free swap entries for
 zap_pte_range()

On Wed, 7 Aug 2024 04:44:44 +0800 Barry Song <21cnbao@...il.com> wrote:

> > > +static bool try_batch_swap_entries_free(struct swap_info_struct *p,
> >
> > Why call it "p" here and not "si" like in the other code you are touching?
> 
> that is because I found other _free_ functions are all using "p":

`p' sucks.  "pointer to something".  It's just lazy.  In this context, "si"
has meaning; lots of it.