linux-kernel - Re: [PATCH v14 3/4] PCI/DOE: Expose the DOE features via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54a52dc904e1df812683b38d8fa534f5c4466bda.camel@wdc.com>
Date: Tue, 6 Aug 2024 06:37:28 +0000
From: Alistair Francis <Alistair.Francis@....com>
To: "lukas@...ner.de" <lukas@...ner.de>, "alistair23@...il.com"
	<alistair23@...il.com>
CC: "chaitanyak@...dia.com" <chaitanyak@...dia.com>, "rdunlap@...radead.org"
	<rdunlap@...radead.org>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "alex.williamson@...hat.com"
	<alex.williamson@...hat.com>, "Jonathan.Cameron@...wei.com"
	<Jonathan.Cameron@...wei.com>, "christian.koenig@....com"
	<christian.koenig@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kch@...dia.com" <kch@...dia.com>,
	"logang@...tatee.com" <logang@...tatee.com>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>
Subject: Re: [PATCH v14 3/4] PCI/DOE: Expose the DOE features via sysfs

On Sun, 2024-08-04 at 08:32 +0200, Lukas Wunner wrote:
> On Wed, Jul 10, 2024 at 12:33:09PM +1000, Alistair Francis wrote:
> > v14:
> >  - Revert back to v12 with extra pci_remove_resource_files() call
> > v13:
> >  - Drop pci_doe_sysfs_init() and use pci_doe_sysfs_group
> >      - As discussed in
> > https://lore.kernel.org/all/20231019165829.GA1381099@bhelgaas/
> >        we can just modify pci_doe_sysfs_group at the DOE init and
> > let
> >        device_add() handle the sysfs attributes.
> > v12:
> >  - Drop pci_doe_features_sysfs_attr_visible()
> > v11:
> >  - Gracefully handle multiple entried of same feature
> >  - Minor fixes and code cleanups
> 
> Hm, it looks like the review comments I left for v11 were never
> addressed :(
> 
> https://lore.kernel.org/all/ZmxvnLDBhkWPrXGK@wunner.de/
> https://lore.kernel.org/all/Zm2RmWnSWEEX8WtV@wunner.de/

No they weren't!

Sorry about that, it seems like I dropped the comments somehow.

I have addressed them in v15

Alistair

> 
> In particular, pci_{create,remove}_resource_files() is not the right
> place
> to dynamically add attributes.  Move the calls of
> pci_doe_sysfs_init()
> and pci_doe_sysfs_teardown() to pci_device_add() and
> pci_destroy_dev(),
> respectively.  This is also what I'm doing for dynamic CMA attributes
> and what Mariusz is doing for LEDs added on enumeration:
> 
> https://lore.kernel.org/all/77f549685f994981c010aebb1e9057aa3555b18a.1719771133.git.lukas@wunner.de/
> (search for pci_cma_publish)
> 
> https://lore.kernel.org/all/20240711083009.5580-3-mariusz.tkaczyk@linux.intel.com/
> (search for pci_npem_create and pci_npem_remove)
> 
> Thanks,
> 
> Lukas