linux-kernel - [PATCH 1/1] selinux: Fix potential counting error in avc_add_xperms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240806065113.1317-1-thunder.leizhen@huaweicloud.com>
Date: Tue,  6 Aug 2024 14:51:13 +0800
From: thunder.leizhen@...weicloud.com
To: Paul Moore <paul@...l-moore.com>,
	Stephen Smalley <stephen.smalley.work@...il.com>,
	Ondrej Mosnacek <omosnace@...hat.com>,
	selinux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Zhen Lei <thunder.leizhen@...wei.com>,
	Nick Kralevich <nnk@...gle.com>,
	Jeff Vander Stoep <jeffv@...gle.com>
Subject: [PATCH 1/1] selinux: Fix potential counting error in avc_add_xperms_decision()

From: Zhen Lei <thunder.leizhen@...wei.com>

The count increases only when a node is successfully added to
the linked list.

Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
---
 security/selinux/avc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index 32eb67fb3e42c0f..7087cd2b802d8d8 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -330,12 +330,12 @@ static int avc_add_xperms_decision(struct avc_node *node,
 {
 	struct avc_xperms_decision_node *dest_xpd;
 
-	node->ae.xp_node->xp.len++;
 	dest_xpd = avc_xperms_decision_alloc(src->used);
 	if (!dest_xpd)
 		return -ENOMEM;
 	avc_copy_xperms_decision(&dest_xpd->xpd, src);
 	list_add(&dest_xpd->xpd_list, &node->ae.xp_node->xpd_head);
+	node->ae.xp_node->xp.len++;
 	return 0;
 }
 
-- 
2.34.1