linux-kernel - Re: [PATCH 0/6] Update the device tree for Ampere's BMC platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23b7e08c-b9eb-408d-ad56-76cce82906e2@amperemail.onmicrosoft.com>
Date: Tue, 6 Aug 2024 13:55:12 +0700
From: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>,
 "Rob Herring (Arm)" <robh@...nel.org>,
 Chanh Nguyen <chanh@...amperecomputing.com>
Cc: devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 linux-aspeed@...ts.ozlabs.org, Andrew Jeffery <andrew@...id.au>,
 OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
 Thang Nguyen <thang@...amperecomputing.com>, linux-kernel@...r.kernel.org,
 Phong Vo <phong@...amperecomputing.com>, Rob Herring <robh+dt@...nel.org>,
 Joel Stanley <joel@....id.au>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Open Source Submission <patches@...erecomputing.com>,
 linux-arm-kernel@...ts.infradead.org,
 Quan Nguyen <quan@...amperecomputing.com>
Subject: Re: [PATCH 0/6] Update the device tree for Ampere's BMC platform



On 05/08/2024 10:59, Andrew Jeffery wrote:
> [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.]
> 
> 
> On Sat, 2024-08-03 at 10:49 +0700, Chanh Nguyen wrote:
>>
>> On 01/08/2024 22:29, Rob Herring (Arm) wrote:
>>>
>>> On Thu, 01 Aug 2024 09:12:10 +0000, Chanh Nguyen wrote:
>>>> Updates the device tree to support some features on Ampere's
>>>> Mt.Mitchell BMC and Ampere's Mt.Jade BMC.
>>>>
>>>> Chanh Nguyen (6):
>>>>     ARM: dts: aspeed: mtjade, mtmitchell: Add OCP temperature sensors
>>>>     ARM: dts: aspeed: mtmitchell: Add I2C temperature sensor alias ports
>>>>     ARM: dts: aspeed: mtmitchell: Add I2C Riser card alias ports
>>>>     ARM: dts: aspeed: mtmitchell: Enable i2c10 and i2c15
>>>>     ARM: dts: aspeed: mtmitchell: Add LEDs
>>>>     ARM: dts: aspeed: mtmitchell: Add I2C FAN controllers
>>>>
>>>>    .../dts/aspeed/aspeed-bmc-ampere-mtjade.dts   |  16 ++
>>>>    .../aspeed/aspeed-bmc-ampere-mtmitchell.dts   | 152 ++++++++++++++++++
>>>>    2 files changed, 168 insertions(+)
>>>>
>>>> --
>>>> 2.43.0
>>>>
>>>>
>>>>
>>>
>>>
>>> My bot found new DTB warnings on the .dts files added or changed in this
>>> series.
>>>
>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>> are fixed by another series. Ultimately, it is up to the platform
>>> maintainer whether these warnings are acceptable or not. No need to reply
>>> unless the platform maintainer has comments.
>>>
>>> If you already ran DT checks and didn't see these error(s), then
>>> make sure dt-schema is up to date:
>>>
>>>     pip3 install dtschema --upgrade
>>>
>>>
>>> New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ampere-mtjade.dtb aspeed/aspeed-bmc-ampere-mtmitchell.dtb' for 20240801091217.1408809-1-chanh@...amperecomputing.com:
>>>
>>> arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dtb: /ahb/apb/bus@...8a000/i2c@.../fan-controller0@20: failed to match any schema with compatible: ['maxim,max31790']
>>> arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dtb: /ahb/apb/bus@...8a000/i2c@.../fan-controller1@2f: failed to match any schema with compatible: ['maxim,max31790']
>>>
>>>
>>
>> Thank Rob for your review!
>>
>> I am aware of the new warnings you mentioned. For more information, the
>> schema binding of "maxim,max31790" is being progressed by other series
>> https://lore.kernel.org/lkml/20240414042246.8681-2-chanh@os.amperecomputing.com/
>>
> 
> For now can you please remove the `maxim,max31790` nodes from your
> devicetree and re-send? As it stands you've been asked to rework what
> you proposed in the thread that you linked, and a quick look at the
> hwmon trees suggests support for the max31790 hasn't been merged.
> 
> You can send a follow-up patch adding the nodes to your devicetree once
> the binding has been merged.
> 
> Andrew

Thank Andrew for your comment!

I'll remove the `maxim,max31790` nodes and send the patch v2

Chanh