linux-kernel - RE: [PATCH v2] iommufd/device: Enforce reserved IOVA also when attached to hwpt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276C2F39301A461FF84EB368CBF2@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Tue, 6 Aug 2024 08:08:49 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Nicolin Chen <nicolinc@...dia.com>, "jgg@...dia.com" <jgg@...dia.com>
CC: "Liu, Yi L" <yi.l.liu@...el.com>, "iommu@...ts.linux.dev"
	<iommu@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] iommufd/device: Enforce reserved IOVA also when
 attached to hwpt_nested

> From: Nicolin Chen <nicolinc@...dia.com>
> Sent: Tuesday, August 6, 2024 1:02 PM
> 
> +iommufd_group_do_replace_reserved_iova(struct iommufd_group *igroup,
> +				       struct iommufd_hw_pagetable *hwpt)
>  {
> -	struct iommufd_hw_pagetable *old_hwpt = igroup->hwpt;
> +	struct iommufd_hwpt_paging *hwpt_paging =
> to_hwpt_paging(hwpt);
>  	struct iommufd_device *cur;
>  	int rc;
> 
>  	lockdep_assert_held(&igroup->lock);
> 
> -	if (!hwpt_is_paging(old_hwpt) ||
> -	    hwpt_paging->ioas != to_hwpt_paging(old_hwpt)->ioas) {
> +	if (!hwpt_paging)
> +		return 0;
> +
> +	if (hwpt_to_ioas(hwpt) &&

this check is always true when hwpt_paging is valid.

Reviewed-by: Kevin Tian <kevin.tian@...el.com>