linux-kernel - Re: [PATCH v3 2/3] Bluetooth: hci_uart: Add support for Amlogic HCI UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33f0f5cb-1b0f-42ce-9e5c-0cd09c564387@kernel.org>
Date: Tue, 6 Aug 2024 10:37:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yang Li <yang.li@...ogic.com>, Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Catalin Marinas
 <catalin.marinas@....com>, Will Deacon <will@...nel.org>
Cc: linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Ye He <ye.he@...ogic.com>
Subject: Re: [PATCH v3 2/3] Bluetooth: hci_uart: Add support for Amlogic HCI
 UART

On 06/08/2024 10:33, Yang Li wrote:
> 
> On 2024/8/6 1:29, Krzysztof Kozlowski wrote:
>> On 02/08/2024 11:39, Yang Li via B4 Relay wrote:
>>> From: Yang Li <yang.li@...ogic.com>
>>>
>> ...
>>
>>> +
>>> +static const struct aml_device_data data_w155s2 = {
>>> +     .iccm_offset = 256 * 1024,
>>> +};
>>> +
>>> +static const struct aml_device_data data_w265s2 = {
>>> +     .iccm_offset = 384 * 1024,
>>> +};
>>> +
>>> +static const struct of_device_id aml_bluetooth_of_match[] = {
>>> +     { .compatible = "amlogic,w155s2-bt", .data = &data_w155s2 },
>>> +     { .compatible = "amlogic,w265s2-bt", .data = &data_w265s2 },
>> Your binding says these devices are compatible, but above suggests it is
>> not. Confusing.
> 
> Yes, the DT binding is incorrect. I will refer to 
> broadcom-bluetooth.yaml to make the modifications as follows:
> 
> properties:
>    compatible:
>      oneOf:
>        - items:
>            - enum:
>                - amlogic,w265s1-bt
>                - amlogic,w265p1-bt
>            - const: amlogic,w155s2-bt
>        - enum:
>            - amlogic,w155s2-bt
>            - amlogic,w265s2-bt
> 
> Please let me know if these changes are acceptable or if there are any 
> further adjustments needed.

Looks good, just please check which devices are compatible with which.

Best regards,
Krzysztof