linux-kernel - Re: [PATCH v3 1/2] zswap: implement a second chance algorithm for dynamic zswap shrinker (fix)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJD7tkZACWjdr6Cow74XO+Kw1Pdt7esHQss03M5f2U6P6Ey_-w@mail.gmail.com>
Date: Mon, 5 Aug 2024 18:07:24 -0700
From: Yosry Ahmed <yosryahmed@...gle.com>
To: Nhat Pham <nphamcs@...il.com>
Cc: akpm@...ux-foundation.org, hannes@...xchg.org, shakeel.butt@...ux.dev, 
	linux-mm@...ck.org, kernel-team@...a.com, linux-kernel@...r.kernel.org, 
	flintglass@...il.com, chengming.zhou@...ux.dev
Subject: Re: [PATCH v3 1/2] zswap: implement a second chance algorithm for
 dynamic zswap shrinker (fix)

On Mon, Aug 5, 2024 at 5:34 PM Nhat Pham <nphamcs@...il.com> wrote:
>
> Fix a small mistake in the referenced bit documentation.
>
> Signed-off-by: Nhat Pham <nphamcs@...il.com>

Acked-by: Yosry Ahmed <yosryahmed@...gle.com>

> ---
>  mm/zswap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index fb3d9cb88785..44a7234a7b11 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -188,8 +188,8 @@ static struct shrinker *zswap_shrinker;
>   *          decompression. For a same value filled page length is 0, and both
>   *          pool and lru are invalid and must be ignored.
>   * referenced - true if the entry recently entered the zswap pool. Unset by the
> - *              dynamic shrinker. The entry is only reclaimed by the dynamic
> - *              shrinker if referenced is unset. See comments in the shrinker
> + *              writeback logic. The entry is only reclaimed by the writeback
> + *              logic if referenced is unset. See comments in the shrinker
>   *              section for context.
>   * pool - the zswap_pool the entry's data is in
>   * handle - zpool allocation handle that stores the compressed page data
> --
> 2.43.0