lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240806090844.GR2636630@kernel.org>
Date: Tue, 6 Aug 2024 10:08:44 +0100
From: Simon Horman <horms@...nel.org>
To: hhorace <hhoracehsu@...il.com>
Cc: johannes@...solutions.net, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	Guillaume Nault <gnault@...hat.com>,
	Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH] wifi: cfg80211: fix bug of mapping AF3x to incorrect
 User Priority

+ Guillaume and Ido

On Mon, Aug 05, 2024 at 03:17:42PM +0800, hhorace wrote:
> According to RFC8325 4.3, Multimedia Streaming: AF31(011010, 26), 
> AF32(011100, 28), AF33(011110, 30) maps to User Priority = 4 
> and AC_VI (Video).
> 
> However, the original code remain the default three Most Significant
> Bits (MSBs) of the DSCP, which makes AF3x map to User Priority = 3
> and AC_BE (Best Effort).
> 
> Signed-off-by: hhorace <hhoracehsu@...il.com>

Adding Guillaume and Ido as this relates to DSCP.

> ---
>  net/wireless/util.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index 082c6f9..4e04618 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -998,7 +998,6 @@ unsigned int cfg80211_classify8021d(struct sk_buff *skb,
>  	 * Diffserv Service Classes no update is needed:
>  	 * - Standard: DF
>  	 * - Low Priority Data: CS1
> -	 * - Multimedia Streaming: AF31, AF32, AF33
>  	 * - Multimedia Conferencing: AF41, AF42, AF43
>  	 * - Network Control Traffic: CS7
>  	 * - Real-Time Interactive: CS4
> @@ -1026,6 +1025,12 @@ unsigned int cfg80211_classify8021d(struct sk_buff *skb,
>  		/* Broadcasting video: CS3 */
>  		ret = 4;
>  		break;
> +	case 26:
> +	case 28:
> +	case 30:
> +		/* Multimedia Streaming: AF31, AF32, AF33 */
> +		ret = 4;
> +		break;
>  	case 40:
>  		/* Signaling: CS5 */
>  		ret = 5;
> -- 
> 2.42.0.windows.2
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ