linux-kernel - Re: [PATCH v2 1/1] iio: light: apds9960: Add proximity and gesture offset calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG=0RqKoMTSYFxHvgVc_mOQSg9X0Y4kQuFoN4ReRj0XvYt0bNA@mail.gmail.com>
Date: Tue, 6 Aug 2024 15:06:20 +0530
From: Abhash jha <abhashkumarjha123@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: linux-iio@...r.kernel.org, lars@...afoo.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] iio: light: apds9960: Add proximity and gesture
 offset calibration

On Sat, Aug 3, 2024 at 7:28 PM Jonathan Cameron <jic23@...nel.org> wrote:
>
> On Thu,  1 Aug 2024 20:08:57 +0530
> Abhash Jha <abhashkumarjha123@...il.com> wrote:
>
> > Proximity and gesture offset registers perform offset correction to
> > improve cross-talk performance. Added `calibbias` to the proximity
> > and gesture channels.
> > Provided facility to set calibbias based on the channel number.
> >
> > Signed-off-by: Abhash Jha <abhashkumarjha123@...il.com>
>
> I nearly applied this with tweaks, but I think there are enough improvements
> that can be made to make it worth bouncing back to you one more time
>
> Thanks,
>
> Jonathan

Hi Jonathan,
I hope I understood what  you were trying to say correctly, I made a 2D array
for the registers and then modified the set_calibbias function accordingly.
Here is the link to the patch v3 :
https://lore.kernel.org/linux-iio/20240804134212.51682-1-abhashkumarjha123@gmail.com/T/#t
Do tell me if there is something else that needs to be changed.

Thanks,
Abhash