lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202408061721.gfnwpv1W-lkp@intel.com>
Date: Tue, 6 Aug 2024 17:42:13 +0800
From: kernel test robot <lkp@...el.com>
To: James Smart <jsmart2021@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Hannes Reinecke <hare@...e.de>, Daniel Wagner <dwagner@...e.de>,
	Ram Vegesna <ram.vegesna@...adcom.com>
Subject: drivers/scsi/elx/efct/efct_hw.c:227:1: warning: the frame size of
 1136 bytes is larger than 1024 bytes

Hi James,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b446a2dae984fa5bd56dd7c3a02a426f87e05813
commit: ebc076b3eddc807729bd81f7bc48e798a3ddc477 scsi: elx: efct: Tie into kernel Kconfig and build process
date:   3 years, 2 months ago
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20240806/202408061721.gfnwpv1W-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240806/202408061721.gfnwpv1W-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408061721.gfnwpv1W-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/scsi/elx/efct/efct_hw.c: In function 'efct_hw_cb_link':
>> drivers/scsi/elx/efct/efct_hw.c:227:1: warning: the frame size of 1136 bytes is larger than 1024 bytes [-Wframe-larger-than=]
     227 | }
         | ^


vim +227 drivers/scsi/elx/efct/efct_hw.c

4df84e8466242d James Smart 2021-06-01  162  
4df84e8466242d James Smart 2021-06-01  163  static int
4df84e8466242d James Smart 2021-06-01  164  efct_hw_cb_link(void *ctx, void *e)
4df84e8466242d James Smart 2021-06-01  165  {
4df84e8466242d James Smart 2021-06-01  166  	struct efct_hw *hw = ctx;
4df84e8466242d James Smart 2021-06-01  167  	struct sli4_link_event *event = e;
4df84e8466242d James Smart 2021-06-01  168  	struct efc_domain *d = NULL;
4df84e8466242d James Smart 2021-06-01  169  	int rc = 0;
4df84e8466242d James Smart 2021-06-01  170  	struct efct *efct = hw->os;
4df84e8466242d James Smart 2021-06-01  171  
4df84e8466242d James Smart 2021-06-01  172  	efct_hw_link_event_init(hw);
4df84e8466242d James Smart 2021-06-01  173  
4df84e8466242d James Smart 2021-06-01  174  	switch (event->status) {
4df84e8466242d James Smart 2021-06-01  175  	case SLI4_LINK_STATUS_UP:
4df84e8466242d James Smart 2021-06-01  176  
4df84e8466242d James Smart 2021-06-01  177  		hw->link = *event;
4df84e8466242d James Smart 2021-06-01  178  		efct->efcport->link_status = EFC_LINK_STATUS_UP;
4df84e8466242d James Smart 2021-06-01  179  
4df84e8466242d James Smart 2021-06-01  180  		if (event->topology == SLI4_LINK_TOPO_NON_FC_AL) {
4df84e8466242d James Smart 2021-06-01  181  			struct efc_domain_record drec = {0};
4df84e8466242d James Smart 2021-06-01  182  
4df84e8466242d James Smart 2021-06-01  183  			efc_log_info(hw->os, "Link Up, NPORT, speed is %d\n",
4df84e8466242d James Smart 2021-06-01  184  				     event->speed);
4df84e8466242d James Smart 2021-06-01  185  			drec.speed = event->speed;
4df84e8466242d James Smart 2021-06-01  186  			drec.fc_id = event->fc_id;
4df84e8466242d James Smart 2021-06-01  187  			drec.is_nport = true;
4df84e8466242d James Smart 2021-06-01  188  			efc_domain_cb(efct->efcport, EFC_HW_DOMAIN_FOUND,
4df84e8466242d James Smart 2021-06-01  189  				      &drec);
4df84e8466242d James Smart 2021-06-01  190  		} else if (event->topology == SLI4_LINK_TOPO_FC_AL) {
4df84e8466242d James Smart 2021-06-01  191  			u8 buf[SLI4_BMBX_SIZE];
4df84e8466242d James Smart 2021-06-01  192  
4df84e8466242d James Smart 2021-06-01  193  			efc_log_info(hw->os, "Link Up, LOOP, speed is %d\n",
4df84e8466242d James Smart 2021-06-01  194  				     event->speed);
4df84e8466242d James Smart 2021-06-01  195  
4df84e8466242d James Smart 2021-06-01  196  			if (!sli_cmd_read_topology(&hw->sli, buf,
4df84e8466242d James Smart 2021-06-01  197  						   &hw->loop_map)) {
4df84e8466242d James Smart 2021-06-01  198  				rc = efct_hw_command(hw, buf, EFCT_CMD_NOWAIT,
4df84e8466242d James Smart 2021-06-01  199  						__efct_read_topology_cb, NULL);
4df84e8466242d James Smart 2021-06-01  200  			}
4df84e8466242d James Smart 2021-06-01  201  
4df84e8466242d James Smart 2021-06-01  202  			if (rc)
4df84e8466242d James Smart 2021-06-01  203  				efc_log_debug(hw->os, "READ_TOPOLOGY failed\n");
4df84e8466242d James Smart 2021-06-01  204  		} else {
4df84e8466242d James Smart 2021-06-01  205  			efc_log_info(hw->os, "%s(%#x), speed is %d\n",
4df84e8466242d James Smart 2021-06-01  206  				     "Link Up, unsupported topology ",
4df84e8466242d James Smart 2021-06-01  207  				     event->topology, event->speed);
4df84e8466242d James Smart 2021-06-01  208  		}
4df84e8466242d James Smart 2021-06-01  209  		break;
4df84e8466242d James Smart 2021-06-01  210  	case SLI4_LINK_STATUS_DOWN:
4df84e8466242d James Smart 2021-06-01  211  		efc_log_info(hw->os, "Link down\n");
4df84e8466242d James Smart 2021-06-01  212  
4df84e8466242d James Smart 2021-06-01  213  		hw->link.status = event->status;
4df84e8466242d James Smart 2021-06-01  214  		efct->efcport->link_status = EFC_LINK_STATUS_DOWN;
4df84e8466242d James Smart 2021-06-01  215  
4df84e8466242d James Smart 2021-06-01  216  		d = efct->efcport->domain;
4df84e8466242d James Smart 2021-06-01  217  		if (d)
4df84e8466242d James Smart 2021-06-01  218  			efc_domain_cb(efct->efcport, EFC_HW_DOMAIN_LOST, d);
4df84e8466242d James Smart 2021-06-01  219  		break;
4df84e8466242d James Smart 2021-06-01  220  	default:
4df84e8466242d James Smart 2021-06-01  221  		efc_log_debug(hw->os, "unhandled link status %#x\n",
4df84e8466242d James Smart 2021-06-01  222  			      event->status);
4df84e8466242d James Smart 2021-06-01  223  		break;
4df84e8466242d James Smart 2021-06-01  224  	}
4df84e8466242d James Smart 2021-06-01  225  
4df84e8466242d James Smart 2021-06-01  226  	return 0;
4df84e8466242d James Smart 2021-06-01 @227  }
4df84e8466242d James Smart 2021-06-01  228  

:::::: The code at line 227 was first introduced by commit
:::::: 4df84e8466242de835416a4ec0c856c0e2ed26eb scsi: elx: efct: Driver initialization routines

:::::: TO: James Smart <jsmart2021@...il.com>
:::::: CC: Martin K. Petersen <martin.petersen@...cle.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ