linux-kernel - Re: [PATCH] iio: adc: ad7124: fix DT configuration parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15304301efe5c23d55984f8a1f2a5016d7be213d.camel@gmail.com>
Date: Tue, 06 Aug 2024 12:45:06 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Dumitru Ceclan <mitrutzceclan@...il.com>
Cc: lars@...afoo.de, jic23@...nel.org, alexandru.tachici@...log.com, 
	Jonathan.Cameron@...wei.com, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dumitru Ceclan <dumitru.ceclan@...log.com>
Subject: Re: [PATCH] iio: adc: ad7124: fix DT configuration parsing

On Tue, 2024-08-06 at 11:51 +0300, Dumitru Ceclan wrote:
> The cfg pointer is set before reading the channel number that the
> configuration should point to. This causes configurations to be shifted
> by one channel.
> For example setting bipolar to the first channel defined in the DT will
> cause bipolar mode to be active on the second defined channel.
> 
> Fix by moving the cfg pointer setting after reading the channel number.
> 
> Fixes: 7b8d045e497a ("iio: adc: ad7124: allow more than 8 channels")
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/iio/adc/ad7124.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 3beed78496c5..672d41bac8ca 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -839,8 +839,6 @@ static int ad7124_parse_channel_config(struct iio_dev
> *indio_dev,
>  	st->channels = channels;
>  
>  	device_for_each_child_node_scoped(dev, child) {
> -		cfg = &st->channels[channel].cfg;
> -
>  		ret = fwnode_property_read_u32(child, "reg", &channel);
>  		if (ret)
>  			return ret;
> @@ -858,6 +856,7 @@ static int ad7124_parse_channel_config(struct iio_dev
> *indio_dev,
>  		st->channels[channel].ain = AD7124_CHANNEL_AINP(ain[0]) |
>  						  AD7124_CHANNEL_AINM(ain[1]);
>  
> +		cfg = &st->channels[channel].cfg;
>  		cfg->bipolar = fwnode_property_read_bool(child, "bipolar");
>  
>  		ret = fwnode_property_read_u32(child, "adi,reference-select",
> &tmp);