linux-kernel - Re: [syzbot] [can?] WARNING: refcount bug in j1939_xtp_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240806105106.2667-1-hdanton@sina.com>
Date: Tue,  6 Aug 2024 18:51:06 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+5a1281566cc25c9881e0@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [can?] WARNING: refcount bug in j1939_xtp_rx_cts

On Mon, 05 Aug 2024 14:29:36 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    743ff02152bc ethtool: Don't check for NULL info in prepare..
> git tree:       net-next
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=162bd19d980000

#syz test net-next  743ff02152bc

--- x/net/can/j1939/transport.c
+++ y/net/can/j1939/transport.c
@@ -1505,6 +1505,7 @@ static struct j1939_session *j1939_sessi
 	session->state = J1939_SESSION_NEW;
 
 	skb_queue_head_init(&session->skb_queue);
+	skb_get(skb);
 	skb_queue_tail(&session->skb_queue, skb);
 
 	skcb = j1939_skb_to_cb(skb);
--