linux-kernel - Re: [PATCH] kbuild: modinst: remove the multithread option from zstd compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806-macho-uber-chipmunk-5ffd3e@lindesnes>
Date: Tue, 6 Aug 2024 13:02:08 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Terrell <terrelln@...com>
Subject: Re: [PATCH] kbuild: modinst: remove the multithread option from zstd
 compression

On Sun, Aug 04, 2024 at 12:33:07PM +0900, Masahiro Yamada wrote:
> Parallel execution is supported by GNU Make:
> 
>   $ make -j<N> modules_install
> 
> It is questionable to enable multithreading within each zstd process
> by default.
> 
> If you still want to do it, you can use the environment variable:
> 
>   $ ZSTD_NBTHREADS=<N> make modules_install
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  scripts/Makefile.modinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index 0afd75472679..04f5229efa6b 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -146,7 +146,7 @@ quiet_cmd_gzip = GZIP    $@
>  quiet_cmd_xz = XZ      $@
>        cmd_xz = $(XZ) --check=crc32 --lzma2=dict=1MiB -f $<
>  quiet_cmd_zstd = ZSTD    $@
> -      cmd_zstd = $(ZSTD) -T0 --rm -f -q $<
> +      cmd_zstd = $(ZSTD) --rm -f -q $<
>  
>  $(dst)/%.ko.gz: $(dst)/%.ko FORCE
>  	$(call cmd,gzip)
> -- 
> 2.43.0
> 

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>