[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20240806113210.1649909-4-yangjihong@bytedance.com>
Date: Tue, 6 Aug 2024 19:32:10 +0800
From: Yang Jihong <yangjihong@...edance.com>
To: peterz@...radead.org,
mingo@...hat.com,
acme@...nel.org,
namhyung@...nel.org,
mark.rutland@....com,
alexander.shishkin@...ux.intel.com,
jolsa@...nel.org,
irogers@...gle.com,
adrian.hunter@...el.com,
kan.liang@...ux.intel.com,
linux-perf-users@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: yangjihong@...edance.com
Subject: [PATCH 3/3] perf dwarf-aux: Fix build fail when HAVE_DWARF_GETLOCATIONS_SUPPORT undefined
commit 3796eba7c137 move #else block of #ifdef HAVE_DWARF_GETLOCATIONS_SUPPORT
code from dwarf-aux.c to dwarf-aux.h, in which die_get_var_range() used ENOTSUP
macro, but dwarf-aux.h was not self-contained and did not include file errno.h.
As a result, the build failed when HAVE_DWARF_GETLOCATIONS_SUPPORT macro was not
defined, and the error log is as follows:
In file included from util/disasm.h:8,
from util/annotate.h:16,
from builtin-top.c:23:
util/dwarf-aux.h: In function ‘die_get_var_range’:
util/dwarf-aux.h:184:10: error: ‘ENOTSUP’ undeclared (first use in this function)
184 | return -ENOTSUP;
| ^~~~~~~
util/dwarf-aux.h:184:10: note: each undeclared identifier is reported only once for each function it appears in
In file included from util/disasm.h:8,
from util/annotate.h:16,
from builtin-report.c:13:
util/dwarf-aux.h: In function ‘die_get_var_range’:
util/dwarf-aux.h:184:10: error: ‘ENOTSUP’ undeclared (first use in this function)
184 | return -ENOTSUP;
| ^~~~~~~
util/dwarf-aux.h:184:10: note: each undeclared identifier is reported only once for each function it appears in
LD arch/perf-in.o
In file included from util/disasm.h:8,
from util/annotate.h:16,
from util/block-range.c:3:
util/dwarf-aux.h: In function ‘die_get_var_range’:
util/dwarf-aux.h:184:10: error: ‘ENOTSUP’ undeclared (first use in this function)
184 | return -ENOTSUP;
| ^~~~~~~
util/dwarf-aux.h:184:10: note: each undeclared identifier is reported only once for each function it appears in
CC trace/beauty/fcntl.o
CC builtin-probe.o
Fixes: 3796eba7c137 ("perf dwarf-aux: Move #else block of #ifdef HAVE_DWARF_GETLOCATIONS_SUPPORT code to the header file")
Signed-off-by: Yang Jihong <yangjihong@...edance.com>
---
tools/perf/util/dwarf-aux.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/dwarf-aux.h b/tools/perf/util/dwarf-aux.h
index 24446412b869..d2903894538e 100644
--- a/tools/perf/util/dwarf-aux.h
+++ b/tools/perf/util/dwarf-aux.h
@@ -5,6 +5,7 @@
* dwarf-aux.h : libdw auxiliary interfaces
*/
+#include <errno.h>
#include <dwarf.h>
#include <elfutils/libdw.h>
#include <elfutils/libdwfl.h>
--
2.25.1
Powered by blists - more mailing lists