linux-kernel - Re: [PATCH -next] powerpc: Fix a config comment typo in asm/percpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa26e911-adb1-8410-5e7c-1ca5a1302e77@huawei.com>
Date: Tue, 6 Aug 2024 20:56:51 +0800
From: Jinjie Ruan <ruanjinjie@...wei.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>, <dennis@...nel.org>,
	<tj@...nel.org>, <cl@...ux.com>, <mpe@...erman.id.au>, <npiggin@...il.com>,
	<naveen@...nel.org>, <linux-mm@...ck.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] powerpc: Fix a config comment typo in asm/percpu.h



On 2024/8/6 20:50, Christophe Leroy wrote:
> 
> 
> Le 06/08/2024 à 13:23, Jinjie Ruan a écrit :
>> [Vous ne recevez pas souvent de courriers de ruanjinjie@...wei.com.
>> Découvrez pourquoi ceci est important à
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> commit 0db880fc865f ("powerpc: Avoid nmi_enter/nmi_exit in real mode
>> interrupt.") has a config comment typo, fix it.
>>
>> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
>> ---
>>   arch/powerpc/include/asm/percpu.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/include/asm/percpu.h
>> b/arch/powerpc/include/asm/percpu.h
>> index 634970ce13c6..c836b16ce30d 100644
>> --- a/arch/powerpc/include/asm/percpu.h
>> +++ b/arch/powerpc/include/asm/percpu.h
>> @@ -23,7 +23,7 @@
>> DECLARE_STATIC_KEY_FALSE(__percpu_first_chunk_is_paged);
>>                  (static_key_enabled(&__percpu_first_chunk_is_paged.key))
>>   #else
>>   #define percpu_first_chunk_is_paged    false
>> -#endif /* CONFIG_PPC64 && CONFIG_SMP */
>> +#endif /* CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK && CONFIG_SMP */
> 
> The #if/#else/#endif section is small and doesn't nest additional
> #ifdefs so the comment is useless and should be removed completely.

OK, I'll send v2 to remove it, thank you!

> 
> Christophe
>