[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a1aa292d-6d61-4cb9-8343-6f38258c176f@kernel.org>
Date: Tue, 6 Aug 2024 15:13:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: xianwei.zhao@...ogic.com, Neil Armstrong <neil.armstrong@...aro.org>,
Jerome Brunet <jbrunet@...libre.com>,
Michael Turquette <mturquette@...libre.com>, Stephen Boyd
<sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Chuan Liu <chuan.liu@...ogic.com>,
Kevin Hilman <khilman@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: amlogic: add some device nodes for C3
On 06/08/2024 12:27, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@...ogic.com>
>
> Add some device nodes for SoC C3, including periphs clock controller
> node, PLL clock controller node, SPICC node, regulator node, NAND
> controller node, sdcard node, Ethernet MAC and PHY node.
>
> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>
> ---
> .../boot/dts/amlogic/amlogic-c3-c302x-aw409.dts | 249 +++++++++++
> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 487 ++++++++++++++++++++-
> 2 files changed, 735 insertions(+), 1 deletion(-)
>
...
> +
> + sd: mmc@...00 {
> + compatible = "amlogic,meson-axg-mmc";
> + reg = <0x0 0x8a000 0x0 0x800>;
> + interrupts = <GIC_SPI 177 IRQ_TYPE_EDGE_RISING>;
> + power-domains = <&pwrc PWRC_C3_SDCARD_ID>;
> + clocks = <&clkc_periphs CLKID_SYS_SD_EMMC_B>,
> + <&clkc_periphs CLKID_SD_EMMC_B>,
> + <&clkc_pll CLKID_FCLK_DIV2>;
> + clock-names = "core", "clkin0", "clkin1";
> + no-mmc;
> + no-sdio;
Hm? Why are these blocks incomplete that they do not handle SDIO? Aren't
you putting board properties into SoC?
Best regards,
Krzysztof
Powered by blists - more mailing lists