linux-kernel - Re: [PATCH v1] arm: dts: st: Add MECIO1 and MECT1S board variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17c21be3-5bdc-48e5-b005-be6018a49106@kernel.org>
Date: Tue, 6 Aug 2024 15:31:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, David Jander <david@...tonic.nl>,
 kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH v1] arm: dts: st: Add MECIO1 and MECT1S board variants

On 06/08/2024 15:15, Oleksij Rempel wrote:
> On Tue, Aug 06, 2024 at 02:39:31PM +0200, Krzysztof Kozlowski wrote:
>> On 06/08/2024 14:03, Oleksij Rempel wrote:
>>> From: David Jander <david@...tonic.nl>
>>>
>>> Introduce device tree support for the MECIO1 and MECT1S board variants.
>>> MECIO1 is an I/O and motor control board used in blood sample analysis
>>> machines. MECT1S is a 1000Base-T1 switch for internal machine networks
>>> of blood sample analysis machines.
>>>
>>> Signed-off-by: David Jander <david@...tonic.nl>
>>> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
>>> ---
>>>  .../devicetree/bindings/arm/stm32/stm32.yaml  |   8 +
>>>  arch/arm/boot/dts/st/Makefile                 |   3 +
>>>  arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts |  48 ++
>>>  arch/arm/boot/dts/st/stm32mp151c-mect1s.dts   | 297 ++++++++++
>>>  arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts |  48 ++
>>>  .../arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi | 533 ++++++++++++++++++
>>>  6 files changed, 937 insertions(+)
>>>  create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mecio1r0.dts
>>>  create mode 100644 arch/arm/boot/dts/st/stm32mp151c-mect1s.dts
>>>  create mode 100644 arch/arm/boot/dts/st/stm32mp153c-mecio1r1.dts
>>>  create mode 100644 arch/arm/boot/dts/st/stm32mp15x-mecio1-io.dtsi
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> index 58099949e8f3a..703d4b574398d 100644
>>> --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then please
>> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
> 
> Ack, I see. stm32.yaml should be in separate patch.

Yes

> 
>> Some warnings can be ignored, especially from --strict run, but the code
>> here looks like it needs a fix. Feel free to get in touch if the warning
>> is not clear.
> 
> What should be done with "ethernet-phy-id2000.a284" appears
> un-documente warnings? Should it be handled by
> Documentation/devicetree/bindings/net/ethernet-phy.yaml?


I think it is documented. checkpatch is not accurate for this one.

Best regards,
Krzysztof