linux-kernel - Re: [PATCH] Revert "perf: Add a counter for number of user access events in context"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+dxQxNV-Bm3q5vzCyfWEzO2Qv-jq29eGVaP-sC-jVyww@mail.gmail.com>
Date: Tue, 6 Aug 2024 07:37:41 -0600
From: Rob Herring <robh@...nel.org>
To: Song Liu <song@...nel.org>
Cc: linux-kernel@...r.kernel.org, Mark Rutland <mark.rutland@....com>, 
	Thomas Gleixner <tglx@...utronix.de>, Will Deacon <will@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] Revert "perf: Add a counter for number of user access
 events in context"

On Mon, Aug 5, 2024 at 5:10 PM Song Liu <song@...nel.org> wrote:
>
> This reverts commit 82ff0c022d19c2ad69a472692bb7ee01ac07a40b.
>
> perf_event->nr_user is not used any more. Remove it.

What are you talking about? It is used whenever
PERF_EVENT_FLAG_USER_READ_CNT is set on an event:

arch/x86/events/core.c:         event->hw.flags |=
PERF_EVENT_FLAG_USER_READ_CNT;
arch/x86/events/core.c: if (!(event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT))
arch/x86/events/core.c: if (!(event->hw.flags & PERF_EVENT_FLAG_USER_READ_CNT))
arch/x86/events/core.c: if (!(hwc->flags & PERF_EVENT_FLAG_USER_READ_CNT))
arch/x86/events/core.c:         !!(event->hw.flags &
PERF_EVENT_FLAG_USER_READ_CNT);
drivers/perf/arm_pmuv3.c:       return event->hw.flags &
PERF_EVENT_FLAG_USER_READ_CNT;
drivers/perf/arm_pmuv3.c:               event->hw.flags |=
PERF_EVENT_FLAG_USER_READ_CNT;
drivers/perf/riscv_pmu.c:               !!(event->hw.flags &
PERF_EVENT_FLAG_USER_READ_CNT) &&
drivers/perf/riscv_pmu.c:       if (!(event->hw.flags &
PERF_EVENT_FLAG_USER_READ_CNT))
drivers/perf/riscv_pmu_legacy.c:        event->hw.flags |=
PERF_EVENT_FLAG_USER_READ_CNT;
drivers/perf/riscv_pmu_legacy.c:        event->hw.flags &=
~PERF_EVENT_FLAG_USER_READ_CNT;
drivers/perf/riscv_pmu_sbi.c:       (hwc->flags &
PERF_EVENT_FLAG_USER_READ_CNT))
drivers/perf/riscv_pmu_sbi.c:       (hwc->flags &
PERF_EVENT_FLAG_USER_READ_CNT))
drivers/perf/riscv_pmu_sbi.c:   event->hw.flags |=
PERF_EVENT_FLAG_USER_READ_CNT;
drivers/perf/riscv_pmu_sbi.c:   event->hw.flags &=
~PERF_EVENT_FLAG_USER_READ_CNT;

Rob