linux-kernel - Re: [PATCH] kbuild: add debug package to pacman PKGBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68b454bb-8d29-4a89-bcca-5ba5a1991209@heusel.eu>
Date: Tue, 6 Aug 2024 16:28:51 +0200
From: Christian Heusel <christian@...sel.eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Nathan Chancellor <nathan@...nel.org>, 
	Jose Fernandez <jose.fernandez@...ux.dev>, Masahiro Yamada <masahiroy@...nel.org>, 
	Nicolas Schier <nicolas@...sle.eu>, Peter Jung <ptr1337@...hyos.org>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: add debug package to pacman PKGBUILD

On 24/08/01 08:53PM, Thomas Weißschuh wrote:
> On 2024-08-01 11:36:37+0000, Nathan Chancellor wrote:
> > Hi Jose,
> > 
> > On Thu, Aug 01, 2024 at 07:29:40AM -0600, Jose Fernandez wrote:
> > > Add a new -debug package to the pacman PKGBUILD that will contain the
> > > vmlinux image for debugging purposes. This package depends on the
> > > -headers package and will be installed in /usr/src/debug/${pkgbase}.
> > > 
> > > The vmlinux image is needed to debug core dumps with tools like crash.
> > > 
> > > Signed-off-by: Jose Fernandez <jose.fernandez@...ux.dev>
> > > Reviewed-by: Peter Jung <ptr1337@...hyos.org>
> > 
> > This appears to add a non-trivial amount of time to the build when benchmarking
> > with Arch Linux's configuration (I measure 9% with hyperfine):
> 
> As nothing more is compiled, I guess this is just the additional
> packaging.

I would expect that the overhead stems from the extra compression that
needs to be done for the resulting package and depending on what you
have set in your /etc/makepkg.conf this can add significant overhead.
For packages that are not planned to be distributed it might make sense
to completely disable compression[0] by setting PKGEXT. The referenced
forum discussion also explains that this can be hard-disabled in the
PKGBUILD itself, but I would prefer if we could respect the user config
in that regard (especially for people who would like to save some space
on their system).

Additionally the default makepkg configuration is ZSTD compression with
a few parameters that are pretty time consuming (as they are meant to be
used by packagers), which will most likely be reverted again in favour
of a more widely applicable set of defaults with the next pacman
package release. See [2] for the related discussion on the Arch Linux
bugtracker.

The rest of the changes looks fine to me, adding in some configuration
options on which package is actually built via the other patch also
sounds good.

Reviewed-by: Christian Heusel <christian@...sel.eu>

Cheers,
Christian

[0]: https://bbs.archlinux.org/viewtopic.php?id=127894
[1]: https://gitlab.archlinux.org/archlinux/packaging/packages/pacman/-/issues/23

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)