linux-kernel - Re: [PATCH v2] crypto: arm64/poly1305

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jpn3ryddqowd6t2yj22z7rfrjkr6may53ned672coghzaa5ims@gnx7q6yx2625>
Date: Tue, 6 Aug 2024 14:47:04 +0000
From: Daniel Gomez <da.gomez@...sung.com>
To: Andy Polyakov <appro@...ptogams.org>
CC: Jia He <justin.he@....com>, Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>, Catalin Marinas
	<catalin.marinas@....com>, Will Deacon <will@...nel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] crypto: arm64/poly1305 - move data to rodata section

On Tue, Aug 06, 2024 at 03:28:25PM GMT, Andy Polyakov wrote:
> > I'm getting the following error with next-20240806
> > 
> > make LLVM=1 ARCH=arm64 allyesconfig
> > make LLVM=1 ARCH=arm64 -j$(nproc)
> > 
> > ld.lld: error: vmlinux.a(arch/arm64/crypto/poly1305-core.o):(function poly1305_blocks_neon: .text+0x3d4): relocation R_AARCH64_ADR_PREL_LO21 out of range: 269166444 is not in [-1048576, 1048575]
> 
> This looks like the original version of the path. At the very least the
> R_AARCH64_ADR_PREL_LO21 relocation is generated for the adr instruction. The
> v2 has adrp and add pair for which the relocations are
> R_AARCH64_ADR_PREL_PG_HI21 and R_AARCH64_ADD_ABS_LO12_NC.
> 

I see, I thought v2 was already part of next-20240806 tag. Reverting v1 and
applying v2 works for me. Thanks for clarifying.

Tested-by: Daniel Gomez <da.gomez@...sung.com>

Daniel