linux-kernel - Re: [PATCH v3 5/9] firmware: arm_scmi: Make MBOX transport a standalone driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrI6NH20rK0-WCuf@pluto>
Date: Tue, 6 Aug 2024 15:59:00 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Sudeep Holla <sudeep.holla@....com>
Cc: Cristian Marussi <cristian.marussi@....com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	arm-scmi@...r.kernel.org, james.quinlan@...adcom.com,
	f.fainelli@...il.com, vincent.guittot@...aro.org,
	etienne.carriere@...com, peng.fan@....nxp.com, michal.simek@....com,
	quic_sibis@...cinc.com, quic_nkela@...cinc.com, ptosi@...gle.com,
	dan.carpenter@...aro.org, souvik.chakravarty@....com
Subject: Re: [PATCH v3 5/9] firmware: arm_scmi: Make MBOX transport a
 standalone driver

On Tue, Aug 06, 2024 at 02:12:39PM +0100, Sudeep Holla wrote:
> On Tue, Jul 30, 2024 at 02:33:14PM +0100, Cristian Marussi wrote:
> > Make SCMI mailbox transport a standalne driver that can be optionally
> > loaded as a module.
> > 

Hi Sudeep,

thanks for havig a look.

> > Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> > ---
> > v2 --> v3
> > - fixed spacing in Kconfig
> > - updated Copyright
> > - use new params in DEFINE_SCMI_TRANSPORT_DRIVER
> > ---
> >  drivers/firmware/arm_scmi/Kconfig             |  4 +-
> >  drivers/firmware/arm_scmi/Makefile            |  3 +-
> >  drivers/firmware/arm_scmi/common.h            |  3 --
> >  drivers/firmware/arm_scmi/driver.c            |  3 --
> >  .../{mailbox.c => scmi_transport_mailbox.c}   | 47 +++++++++++++------
> >  5 files changed, 38 insertions(+), 22 deletions(-)
> >  rename drivers/firmware/arm_scmi/{mailbox.c => scmi_transport_mailbox.c} (87%)
> 
> I am happy with the changes in the series, they all look good. I wonder if
> it makes sense to move transport drivers into a separate folder
> drivers/firmware/arm_scmi/transport/{mailbox,smc,optee,virtio}.c
> 
> In scmi_transport_*.c, I see scmi is redundant and transport can be eliminated
> by moving all under the folder with that name. Thoughts ?
> 

Yes it is a possigility, not sure if there is any (trivial) drawback to
solve while movinf, but consider that the final name for the .ko LKM has to
have the scmi_transport prefix somehow to be able to live in the tree and distinguish
those LKMs from (vendor) protocols ones...so I would have anyway to craft an
scmi_ naming in the Makefile

Thanks,
Cristian