linux-kernel - Re: [PATCH v2 1/1] livepatch: Add using attribute to klp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <81AC0E7E-24D8-4768-B1A2-CD3688C1525D@gmail.com>
Date: Tue, 6 Aug 2024 23:21:13 +0800
From: zhang warden <zhangwarden@...il.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>,
 Miroslav Benes <mbenes@...e.cz>,
 Jiri Kosina <jikos@...nel.org>,
 Petr Mladek <pmladek@...e.com>,
 Joe Lawrence <joe.lawrence@...hat.com>
Cc: live-patching@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] livepatch: Add using attribute to klp_func for
 using function show



> On Aug 5, 2024, at 14:46, zhangyongde.zyd <zhangwarden@...il.com> wrote:
> 
> From: Wardenjohn <zhangwarden@...il.com>
> 
> 
> static void klp_init_func_early(struct klp_object *obj,
> struct klp_func *func)
> {
> + func->using = false;
> kobject_init(&func->kobj, &klp_ktype_func);
> list_add_tail(&func->node, &obj->func_list);
> }

I reviewed my mail again and found some typos and point them out first.

func->using = false
is a remaining mistake by the previous patch which will remove in the next patch.

> 
> + * 
> + * When this patch is in transition, all functions of this patch will
> + * set to be unknown
> */
This comment is left and become useless, it will be removed	in the next patch.

Thanks!
Wardenjohn.