linux-kernel - Re: [PATCH v3 17/17] dt-bindings: net: wireless: cc33xx: Add ti,cc33xx.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0da6f8ce-e220-47b9-86dd-537ad4b328e5@ti.com>
Date: Wed, 7 Aug 2024 18:51:42 +0300
From: "Nemanov, Michael" <michael.nemanov@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Kalle Valo <kvalo@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC: Sabeeh Khan <sabeeh-khan@...com>
Subject: Re: [PATCH v3 17/17] dt-bindings: net: wireless: cc33xx: Add
 ti,cc33xx.yaml

On 8/7/2024 10:06 AM, Krzysztof Kozlowski wrote:
> On 06/08/2024 19:00, Michael Nemanov wrote:
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,cc3300
>> +      - ti,cc3301
>> +      - ti,cc3350
>> +      - ti,cc3351
>> +
>> +  reg:
>> +    description:
>> +      must be set to 2
> 
> Then just const: 2 and drop free form text.
> 
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    description:
>> +      The out-of-band interrupt line.
>> +      Can be IRQ_TYPE_EDGE_RISING or IRQ_TYPE_LEVEL_HIGH.
>> +      If property is omitted, SDIO in-band IRQ will be used.
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    // SDIO example:
> 
> Drop, obvious.
> 
>> +    mmc {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        wifi@1{
> 
> Missing space.
> 
> Also, this does not match reg. Test your DTS with W=1 and FIX ALL warnings.
> 
> Best regards,
> Krzysztof
> 

Will fix all above.

I'm currently testing my .yaml with:
make dt_binding_check DT_CHECKER_FLAGS=-m \ 
DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml

It reports no warnings. Adding W=1 doesn't seem to change anything. Am I 
missing something?

Thanks and regards,
Michael.