| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev>
Date: Wed, 7 Aug 2024 19:01:46 +0300
From: claudiu beznea <claudiu.beznea@...on.dev>
To: Andrei Simion <andrei.simion@...rochip.com>, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, nicolas.ferre@...rochip.com,
alexandre.belloni@...tlin.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: microchip: Rename node, sub-node, and clean up
spacing
Hi, Andrei,
On 23.07.2024 16:12, Andrei Simion wrote:
> Cosmetic work:
Can you please format it as follows:
> Rename the eeprom node according to device tree specification.
One patch for this.
> Rename the usb node according to device tree specification.
One patch for this.
> Rename the led sub nodes according to device tree specification.
One patch for this.
> Rename the pmic node according to the device tree specification.
One patch for this.
> Clean up spacing and indentation.
One patch for this.
>
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>
> ---
> Modifications Based On:
> https://lore.kernel.org/linux-arm-kernel/c4b23da5-10fc-476e-8acc-8ba0815f5def@kernel.org/
You had here 6 patches all addressing "Align the eeprom nodename".
Few comments bellow.
Thank you,
Claudiu Beznea
> ---
> arch/arm/boot/dts/microchip/aks-cdu.dts | 12 +++++-----
> arch/arm/boot/dts/microchip/animeo_ip.dts | 10 ++++----
> .../dts/microchip/at91-cosino_mega2560.dts | 2 +-
> arch/arm/boot/dts/microchip/at91-foxg20.dts | 4 ++--
> .../arm/boot/dts/microchip/at91-qil_a9260.dts | 4 ++--
> .../boot/dts/microchip/at91-sam9_l9260.dts | 2 +-
> .../arm/boot/dts/microchip/at91-sam9x60ek.dts | 6 ++---
> .../dts/microchip/at91-sama5d27_som1.dtsi | 2 +-
> .../dts/microchip/at91-sama5d27_som1_ek.dts | 14 +++++------
> .../dts/microchip/at91-sama5d27_wlsom1.dtsi | 2 +-
> .../dts/microchip/at91-sama5d29_curiosity.dts | 2 +-
> .../boot/dts/microchip/at91-sama5d2_icp.dts | 10 ++++----
> .../dts/microchip/at91-sama5d2_ptc_ek.dts | 8 +++----
> .../dts/microchip/at91-sama5d2_xplained.dts | 8 +++----
> .../dts/microchip/at91-sama5d3_xplained.dts | 6 ++---
> .../dts/microchip/at91-sama5d4_ma5d4evk.dts | 6 ++---
> .../dts/microchip/at91-sama5d4_xplained.dts | 6 ++---
> .../arm/boot/dts/microchip/at91-sama5d4ek.dts | 6 ++---
> .../arm/boot/dts/microchip/at91-sama7g5ek.dts | 2 +-
> arch/arm/boot/dts/microchip/at91-vinco.dts | 6 ++---
> arch/arm/boot/dts/microchip/at91rm9200.dtsi | 4 ++--
> arch/arm/boot/dts/microchip/at91rm9200ek.dts | 10 ++++----
> arch/arm/boot/dts/microchip/at91sam9260.dtsi | 4 ++--
> arch/arm/boot/dts/microchip/at91sam9260ek.dts | 10 ++++----
> arch/arm/boot/dts/microchip/at91sam9261.dtsi | 4 ++--
> arch/arm/boot/dts/microchip/at91sam9261ek.dts | 10 ++++----
> arch/arm/boot/dts/microchip/at91sam9263.dtsi | 4 ++--
> arch/arm/boot/dts/microchip/at91sam9263ek.dts | 12 +++++-----
> arch/arm/boot/dts/microchip/at91sam9g20ek.dts | 4 ++--
> .../boot/dts/microchip/at91sam9g20ek_2mmc.dts | 4 ++--
> .../dts/microchip/at91sam9g20ek_common.dtsi | 6 ++---
> .../at91sam9g25-gardena-smart-gateway.dts | 24 +++++++++----------
> arch/arm/boot/dts/microchip/at91sam9g45.dtsi | 6 ++---
> .../boot/dts/microchip/at91sam9m10g45ek.dts | 6 ++---
> arch/arm/boot/dts/microchip/at91sam9n12.dtsi | 4 ++--
> arch/arm/boot/dts/microchip/at91sam9n12ek.dts | 10 ++++----
> arch/arm/boot/dts/microchip/at91sam9rl.dtsi | 2 +-
> arch/arm/boot/dts/microchip/at91sam9rlek.dts | 2 +-
> arch/arm/boot/dts/microchip/at91sam9x5.dtsi | 6 ++---
> arch/arm/boot/dts/microchip/at91sam9x5cm.dtsi | 4 ++--
> arch/arm/boot/dts/microchip/ethernut5.dts | 4 ++--
> arch/arm/boot/dts/microchip/evk-pro3.dts | 4 ++--
> arch/arm/boot/dts/microchip/mpa1600.dts | 2 +-
> arch/arm/boot/dts/microchip/pm9g45.dts | 4 ++--
> arch/arm/boot/dts/microchip/sam9x60.dtsi | 6 ++---
> arch/arm/boot/dts/microchip/sama5d2.dtsi | 6 ++---
> arch/arm/boot/dts/microchip/sama5d3.dtsi | 6 ++---
> arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
> arch/arm/boot/dts/microchip/sama5d3xmb.dtsi | 6 ++---
> .../boot/dts/microchip/sama5d3xmb_cmp.dtsi | 2 +-
> arch/arm/boot/dts/microchip/sama5d4.dtsi | 6 ++---
> arch/arm/boot/dts/microchip/tny_a9263.dts | 2 +-
> .../boot/dts/microchip/usb_a9260_common.dtsi | 4 ++--
> arch/arm/boot/dts/microchip/usb_a9263.dts | 4 ++--
> 54 files changed, 156 insertions(+), 156 deletions(-)
>
[ ... ]
>
> @@ -258,10 +258,10 @@ pinctrl_i2c1_default: i2c1_default {
> };
>
> pinctrl_i2c1_gpio: i2c1_gpio {
> - pinmux = <PIN_PD4__GPIO>,
> - <PIN_PD5__GPIO>;
> - bias-disable;
> - };
> + pinmux = <PIN_PD4__GPIO>,
> + <PIN_PD5__GPIO>;
> + bias-disable;
> + };
>
Please remove this extra line here, too.
[ ... ]
> - usb1: gadget@...78000 {
> + usb1: usb@...78000 {
> atmel,vbus-gpio = <&pioA 25 GPIO_ACTIVE_HIGH>;
> status = "okay";
> };
> @@ -86,7 +86,7 @@ pinctrl@...ff200 {
> mmc0 {
> pinctrl_board_mmc0: mmc0-board {
> atmel,pins =
> - <AT91_PIOE 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* PE18 gpio CD pin pull up and deglitch */
> + <AT91_PIOE 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* PE18 gpio CD pin pull up and deglitch */
What was wrong here?
> AT91_PIOE 19 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP>; /* PE19 gpio WP pin pull up */
> };
> };
> @@ -207,7 +207,7 @@ data@...0000 {
> };
> };
[ ...]
> diff --git a/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts b/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts
> index af70eb8a3a02..60560e4c1696 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts
> +++ b/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts
> @@ -37,71 +37,71 @@ button {
> leds {
> compatible = "gpio-leds";
>
> - power_blue {
> + led-0 {
> label = "smartgw:power:blue";
> gpios = <&pioC 21 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - power_green {
> + led-1 {
> label = "smartgw:power:green";
> gpios = <&pioC 20 GPIO_ACTIVE_HIGH>;
> default-state = "on";
> };
>
> - power_red {
> + led-2 {
> label = "smartgw:power:red";
> gpios = <&pioC 19 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - radio_blue {
> + led-3 {
> label = "smartgw:radio:blue";
> gpios = <&pioC 18 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - radio_green {
> + led-4 {
> label = "smartgw:radio:green";
> gpios = <&pioC 17 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - radio_red {
> + led-5 {
> label = "smartgw:radio:red";
> gpios = <&pioC 16 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - internet_blue {
> + led-6 {
> label = "smartgw:internet:blue";
> gpios = <&pioC 15 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - internet_green {
> + led-7 {
> label = "smartgw:internet:green";
> gpios = <&pioC 14 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - internet_red {
> + led-8 {
> label = "smartgw:internet:red";
> gpios = <&pioC 13 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - heartbeat {
> + led-9 {
> label = "smartgw:heartbeat";
> gpios = <&pioB 8 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
>
> - pb18 {
> + led-pb18 {
> status = "disabled";
> };
>
> - pd21 {
> + led-pd21 {
Why used led-<old-label> for some leds and led-<integer> for other? Valid
for other files.
Powered by blists - more mailing lists