lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b897efe95b80f631d0e0fba70d08d7db@manjaro.org>
Date: Wed, 07 Aug 2024 18:26:15 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Florian Klink <flokli@...kli.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Sebastian Reichel <sebastian.reichel@...labora.com>, Kever Yang
 <kever.yang@...k-chips.com>, Muhammed Efe Cetin <efectn@...tonmail.com>,
 FUKAUMI Naoki <naoki@...xa.com>, Tamás Szűcs
 <tszucs@...tonmail.ch>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add rfkill node for M.2 E wifi on
 orangepi-5-plus

Hello Florian,

On 2024-08-07 18:20, Florian Klink wrote:
> This follows the same logic as 82d40b141a4c7ab66, which did the same
> for rock-5b.

Please use the standard format for referencing commits, i.e. 
82d40b141a4c
("arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b").

> The GPIO pin connecting the WiFi enable signal inside the M.2 Key E 
> slot
> is the same as there.
> 
> This can be validated in
> arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dtsi from Armbian
> rk-5.10-rkr4 kernel, which contains a `wifi_disable` node with that 
> same
> GPIO pin.

This might be used as a reference, but please provide a permanent link
to the actual source code in the referenced downstream repository.

> Signed-off-by: Florian Klink <flokli@...kli.de>
> Tested-by: Florian Klink <flokli@...kli.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> index e74871491ef5..c3a6812cc93a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> @@ -105,6 +105,13 @@ led {
>  		};
>  	};
> 
> +	rfkill {
> +		compatible = "rfkill-gpio";
> +		label = "rfkill-pcie-wlan";
> +		radio-type = "wlan";
> +		shutdown-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>;
> +	};
> +
>  	sound {
>  		compatible = "simple-audio-card";
>  		pinctrl-names = "default";

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ