linux-kernel - Re: [PATCH bpf-next] bpf: remove __btf_name_valid() and change to btf_name_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <659e71b8-e714-4141-901f-3b494a49a9e9@oracle.com>
Date: Wed, 7 Aug 2024 17:53:14 +0100
From: Alan Maguire <alan.maguire@...cle.com>
To: Jeongjun Park <aha310510@...il.com>, martin.lau@...ux.dev
Cc: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, eddyz87@...il.com,
        song@...nel.org, yonghong.song@...ux.dev, john.fastabend@...il.com,
        kpsingh@...nel.org, sdf@...ichev.me, haoluo@...gle.com,
        jolsa@...nel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: remove __btf_name_valid() and change to
 btf_name_valid_identifier()

On 07/08/2024 15:31, Jeongjun Park wrote:
> __btf_name_valid() can be completely replaced with 
> btf_name_valid_identifier, and since most of the time you already call 
> btf_name_valid_identifier instead of __btf_name_valid , it would be 
> appropriate to rename the __btf_name_valid function to 
> btf_name_valid_identifier and remove __btf_name_valid.
> 
> Signed-off-by: Jeongjun Park <aha310510@...il.com>

Looks good to me

Reviewed-by: Alan Maguire <alan.maguire@...cle.com>

> ---
>  kernel/bpf/btf.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>