linux-kernel - Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807170014.GB17382@yjiang5-mobl.amr.corp.intel.com>
Date: Wed, 7 Aug 2024 10:00:14 -0700
From: Yunhong Jiang <yunhong.jiang@...ux.intel.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-acpi@...r.kernel.org, linux-hyperv@...r.kernel.org,
	haiyangz@...rosoft.com, krzk+dt@...nel.org, x86@...nel.org,
	wei.liu@...nel.org, dave.hansen@...ux.intel.com,
	devicetree@...r.kernel.org, hpa@...or.com,
	linux-kernel@...r.kernel.org, bp@...en8.de, tglx@...utronix.de,
	mingo@...hat.com, rafael@...nel.org, kys@...rosoft.com,
	kirill.shutemov@...ux.intel.com, conor+dt@...nel.org,
	lenb@...nel.org, decui@...rosoft.com
Subject: Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

On Tue, Aug 06, 2024 at 05:38:25PM -0600, Rob Herring (Arm) wrote:
> 
> On Tue, 06 Aug 2024 15:12:32 -0700, Yunhong Jiang wrote:
> > Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs.
> > 
> > Signed-off-by: Yunhong Jiang <yunhong.jiang@...ux.intel.com>
> > ---
> >  .../devicetree/bindings/x86/wakeup.yaml       | 41 +++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/x86/wakeup.yaml
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/x86/wakeup.yaml:4:1: [error] syntax error: expected '<document start>', but found '<block mapping start>' (syntax)
> ./Documentation/devicetree/bindings/x86/wakeup.yaml:41:111: [warning] line too long (153 > 110 characters) (line-length)
> 
> dtschema/dtc warnings/errors:
> make[2]: *** Deleting file 'Documentation/devicetree/bindings/x86/wakeup.example.dts'
> Documentation/devicetree/bindings/x86/wakeup.yaml:4:1: did not find expected <document start>
> make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/x86/wakeup.example.dts] Error 1
> make[2]: *** Waiting for unfinished jobs....
> ./Documentation/devicetree/bindings/x86/wakeup.yaml:4:1: did not find expected <document start>
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/x86/wakeup.yaml: ignoring, error parsing file
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240806221237.1634126-3-yunhong.jiang@linux.intel.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 
I remember I ran 'make dt_binding_check' in the early development stage, but
possibly missed the error information. Will fix this.

Thank you
--jyh