linux-kernel - Re: [PATCH next] sched: make printk safe when rq lock is held

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408080114.hpttUZjC-lkp@intel.com>
Date: Thu, 8 Aug 2024 01:31:54 +0800
From: kernel test robot <lkp@...el.com>
To: Menglong Dong <menglong8.dong@...il.com>, peterz@...radead.org
Cc: oe-kbuild-all@...ts.linux.dev, mingo@...hat.com, juri.lelli@...hat.com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com, linux-kernel@...r.kernel.org,
	Menglong Dong <dongml2@...natelecom.cn>,
	Bin Lai <laib2@...natelecom.cn>
Subject: Re: [PATCH next] sched: make printk safe when rq lock is held

Hi Menglong,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20240806]

url:    https://github.com/intel-lab-lkp/linux/commits/Menglong-Dong/sched-make-printk-safe-when-rq-lock-is-held/20240806-155153
base:   next-20240806
patch link:    https://lore.kernel.org/r/20240806074131.36007-1-dongml2%40chinatelecom.cn
patch subject: [PATCH next] sched: make printk safe when rq lock is held
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240808/202408080114.hpttUZjC-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240808/202408080114.hpttUZjC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408080114.hpttUZjC-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/sched/core.c:88:
   kernel/sched/sched.h: In function 'rq_pin_lock':
>> kernel/sched/sched.h:1705:9: error: implicit declaration of function '__printk_safe_enter'; did you mean '__printk_deferred_enter'? [-Wimplicit-function-declaration]
    1705 |         __printk_safe_enter();
         |         ^~~~~~~~~~~~~~~~~~~
         |         __printk_deferred_enter
   kernel/sched/sched.h: In function 'rq_unpin_lock':
>> kernel/sched/sched.h:1722:9: error: implicit declaration of function '__printk_safe_exit'; did you mean '__printk_ratelimit'? [-Wimplicit-function-declaration]
    1722 |         __printk_safe_exit();
         |         ^~~~~~~~~~~~~~~~~~
         |         __printk_ratelimit


vim +1705 kernel/sched/sched.h

  1690	
  1691	/*
  1692	 * Lockdep annotation that avoids accidental unlocks; it's like a
  1693	 * sticky/continuous lockdep_assert_held().
  1694	 *
  1695	 * This avoids code that has access to 'struct rq *rq' (basically everything in
  1696	 * the scheduler) from accidentally unlocking the rq if they do not also have a
  1697	 * copy of the (on-stack) 'struct rq_flags rf'.
  1698	 *
  1699	 * Also see Documentation/locking/lockdep-design.rst.
  1700	 */
  1701	static inline void rq_pin_lock(struct rq *rq, struct rq_flags *rf)
  1702	{
  1703		rf->cookie = lockdep_pin_lock(__rq_lockp(rq));
  1704	
> 1705		__printk_safe_enter();
  1706	#ifdef CONFIG_SCHED_DEBUG
  1707		rq->clock_update_flags &= (RQCF_REQ_SKIP|RQCF_ACT_SKIP);
  1708		rf->clock_update_flags = 0;
  1709	# ifdef CONFIG_SMP
  1710		SCHED_WARN_ON(rq->balance_callback && rq->balance_callback != &balance_push_callback);
  1711	# endif
  1712	#endif
  1713	}
  1714	
  1715	static inline void rq_unpin_lock(struct rq *rq, struct rq_flags *rf)
  1716	{
  1717	#ifdef CONFIG_SCHED_DEBUG
  1718		if (rq->clock_update_flags > RQCF_ACT_SKIP)
  1719			rf->clock_update_flags = RQCF_UPDATED;
  1720	#endif
  1721	
> 1722		__printk_safe_exit();
  1723		lockdep_unpin_lock(__rq_lockp(rq), rf->cookie);
  1724	}
  1725	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki