linux-kernel - Re: [PATCH] treewide: remove unnecessary <linux/version.h> inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrO623duqRRWS5di@bergen>
Date: Wed, 7 Aug 2024 20:20:11 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] treewide: remove unnecessary <linux/version.h> inclusion

On Thu 08 Aug 2024 02:47:28 GMT, Masahiro Yamada wrote:
> These files do not use any macros defined in <linux/version.h>.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  drivers/accessibility/speakup/genmap.c                | 1 -
>  drivers/accessibility/speakup/makemapdata.c           | 1 -
>  drivers/staging/media/atomisp/include/linux/atomisp.h | 1 -
>  samples/trace_events/trace_custom_sched.c             | 1 -
>  sound/soc/codecs/cs42l42.c                            | 1 -
>  5 files changed, 5 deletions(-)
> 

Re-checking with

    $ git grep -rle '#include <linux/version.h>' >files-including-version.h
    $ <files-including-version.h xargs git grep -lr -eLINUX_VERSION_{CODE,MAJOR,PATCHLEVEL,SUBLEVEL} -e KERNEL_VERSION >using-macros-from-version.h
    $ diff files-including-version.h using-macros-from-version.h 

reveals that also

    tools/testing/selftests/bpf/progs/dev_cgroup.c
    tools/testing/selftests/bpf/progs/netcnt_prog.c
    tools/testing/selftests/bpf/progs/test_map_lock.c
    tools/testing/selftests/bpf/progs/test_send_signal_kern.c
    tools/testing/selftests/bpf/progs/test_spin_lock.c
    tools/testing/selftests/bpf/progs/test_tcp_estats.c
    tools/testing/selftests/wireguard/qemu/init.c

are including but not using linux/version.h.  This shall probably not 
go through kbuild tree, so it looks complete (enough) to me, thanks!

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)