linux-kernel - Re: [PATCH] leds: blinkm: fix CONFIG_LEDS_CLASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807181434.qzzydzc4xkckw4vf@libretux>
Date: Wed, 7 Aug 2024 13:14:34 -0500
From: Joseph Strauss <jstrauss@...lbox.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: pavel@....cz, lee@...nel.org, andriy.shevchenko@...ux.intel.com,
	jernej.skrabec@...il.com, duje.mihanovic@...le.hr,
	linux@...ssschuh.net, ansuelsmth@...il.com,
	patrick.rudolph@...ements.com, gnstark@...utedevices.com,
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: blinkm: fix CONFIG_LEDS_CLASS_MULTICOLOR dependency

On 24/08/07 09:55AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> With CONFIG_LEDS_CLASS_MULTICOLOR=m, a builtin leds-blinkm driver causes
> a link failure:
> 
> arm-linux-gnueabi-ld: drivers/leds/leds-blinkm.o: in function `blinkm_set_mc_brightness':
> leds-blinkm.c:(.text.blinkm_set_mc_brightness+0xc): undefined reference to `led_mc_calc_color_components'
> 
> Add a more specific dependency that only allows multicoler mode to
> be enabled for blinkm if it can build and link.
> 
> Fixes: 56e8c56c9af0 ("leds: Add multicolor support to BlinkM LED driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/leds/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 41214c9b93ba..818c8bdd047e 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -838,7 +838,7 @@ config LEDS_BLINKM
>  config LEDS_BLINKM_MULTICOLOR
>  	bool "Enable multicolor support for BlinkM I2C RGB LED"
>  	depends on LEDS_BLINKM
> -	depends on LEDS_CLASS_MULTICOLOR
> +	depends on LEDS_CLASS_MULTICOLOR=y || LEDS_CLASS_MULTICOLOR=LEDS_BLINKM
>  	help
>  	  This option enables multicolor sysfs class support for BlinkM LED and
>  	  disables the older, separated sysfs interface
> -- 
> 2.39.2
> 
Hi,

I was able to reproduce the issue and the fix works. Thank you!

Acked-by: Joseph Strauss <jstrauss@...lbox.org>