linux-kernel - Re: [PATCH v2 0/5] serial: 8250: omap: Add am62 wakeup support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7hed70kvru.fsf@baylibre.com>
Date: Wed, 07 Aug 2024 11:55:33 -0700
From: Kevin Hilman <khilman@...libre.com>
To: Markus Schneider-Pargmann <msp@...libre.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Markus Schneider-Pargmann
 <msp@...libre.com>, Tony Lindgren <tony@...mide.com>, Vignesh Raghavendra
 <vigneshr@...com>, Ronald Wahl <ronald.wahl@...itan.com>, Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>, Thomas Richard
 <thomas.richard@...tlin.com>, Thomas Gleixner <tglx@...utronix.de>, Udit
 Kumar <u-kumar1@...com>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>
Cc: Vibhore Vardhan <vibhore@...com>, Dhruva Gole <d-gole@...com>,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v2 0/5] serial: 8250: omap: Add am62 wakeup support

Markus Schneider-Pargmann <msp@...libre.com> writes:

> v2
> --
>
> In Version 2 I removed the Partial-IO specific patches as these can't be
> tested due to power issues in Partial-IO on am62-lp-sk and similar
> boards.
>
> I added a patch to add DT 'wakeup-source' support.
>
> Series
> ------
>
> To support wakeup from several low power modes on am62, don't always
> enable device wakeup. Instead only set it to wakeup capable. A
> devicetree property 'wakeup-source' can be used to enable wakeup. The
> user is also able to control if wakeup is enabled through sysfs.

For my low-power constraints series[1], it's also important to not have
the UART wakeups unconditionally enabled, so I like the defaults
proposed in this series.  Thanks!

I tested on k3-am62a7-sk along with my constraints changes and all is well.

Reviewed-by: Kevin Hilman <khilman@...libre.com>
Tested-by: Kevin Hilman <khilman@...libre.com>

Kevin

[1] https://lore.kernel.org/all/20240805-lpm-v6-10-constraints-pmdomain-v1-0-d186b68ded4c@baylibre.com/