linux-kernel - Re: [PATCH v2 3/7] mm, slab: move kfence_shutdown_cache() outside slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG48ez0j7qx3mCtQwq-KfkG+nj_k7w9mmwL=FDx_sMSVphhncg@mail.gmail.com>
Date: Wed, 7 Aug 2024 21:11:50 +0200
From: Jann Horn <jannh@...gle.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: "Paul E. McKenney" <paulmck@...nel.org>, Joel Fernandes <joel@...lfernandes.org>, 
	Josh Triplett <josh@...htriplett.org>, Boqun Feng <boqun.feng@...il.com>, 
	Christoph Lameter <cl@...ux.com>, David Rientjes <rientjes@...gle.com>, Steven Rostedt <rostedt@...dmis.org>, 
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Lai Jiangshan <jiangshanlai@...il.com>, 
	Zqiang <qiang.zhang1211@...il.com>, Julia Lawall <Julia.Lawall@...ia.fr>, 
	Jakub Kicinski <kuba@...nel.org>, "Jason A. Donenfeld" <Jason@...c4.com>, 
	"Uladzislau Rezki (Sony)" <urezki@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Roman Gushchin <roman.gushchin@...ux.dev>, Hyeonggon Yoo <42.hyeyoo@...il.com>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, rcu@...r.kernel.org, 
	Alexander Potapenko <glider@...gle.com>, Marco Elver <elver@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, 
	kasan-dev@...glegroups.com, Mateusz Guzik <mjguzik@...il.com>
Subject: Re: [PATCH v2 3/7] mm, slab: move kfence_shutdown_cache() outside slab_mutex

On Wed, Aug 7, 2024 at 12:31 PM Vlastimil Babka <vbabka@...e.cz> wrote:
> kfence_shutdown_cache() is called under slab_mutex when the cache is
> destroyed synchronously, and outside slab_mutex during the delayed
> destruction of SLAB_TYPESAFE_BY_RCU caches.
>
> It seems it should always be safe to call it outside of slab_mutex so we
> can just move the call to kmem_cache_release(), which is called outside.
>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>

Reviewed-by: Jann Horn <jannh@...gle.com>